Ping new shared channels remotes immediately (#25850)

* option for auto inviting plugin to all shared channels.

* auto-invite remotes to shared channels when flag set

* fix unit test

* immediately ping new remotes; fix unique siteurl bug

* make i18n-extract

* fix translations

* fix merge conflicts

* make modules-tidy

* revert accidental go.mod change

* revert accidental go.sum changes

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

server/platform/services/remotecluster/ping.go

@@ -13,6 +13,27 @@ import (
 	"github.com/mattermost/mattermost/server/public/shared/mlog"
 )
 
+// PingNow emits a ping immediately without waiting for next ping loop.
+func (rcs *Service) PingNow(rc *model.RemoteCluster) {
+	online := rc.IsOnline()
+
+	if err := rcs.pingRemote(rc); err != nil {
+		rcs.server.Log().Log(mlog.LvlRemoteClusterServiceWarn, "Remote cluster ping failed",
+			mlog.String("remote", rc.DisplayName),
+			mlog.String("remoteId", rc.RemoteId),
+			mlog.String("pluginId", rc.PluginID),
+			mlog.Err(err),
+		)
+	}
+
+	if online != rc.IsOnline() {
+		if metrics := rcs.server.GetMetrics(); metrics != nil {
+			metrics.IncrementRemoteClusterConnStateChangeCounter(rc.RemoteId, rc.IsOnline())
+		}
+		rcs.fireConnectionStateChgEvent(rc)
+	}
+}
+
 // pingLoop periodically sends a ping to all remote clusters.
 func (rcs *Service) pingLoop(done <-chan struct{}) {
 	pingChan := make(chan *model.RemoteCluster, MaxConcurrentSends*2)
@@ -72,24 +93,7 @@ func (rcs *Service) pingEmitter(pingChan <-chan *model.RemoteCluster, done <-cha
 			if rc == nil {
 				return
 			}
-
-			online := rc.IsOnline()
-
-			if err := rcs.pingRemote(rc); err != nil {
-				rcs.server.Log().Log(mlog.LvlRemoteClusterServiceWarn, "Remote cluster ping failed",
-					mlog.String("remote", rc.DisplayName),
-					mlog.String("remoteId", rc.RemoteId),
-					mlog.String("pluginId", rc.PluginID),
-					mlog.Err(err),
-				)
-			}
-
-			if online != rc.IsOnline() {
-				if metrics := rcs.server.GetMetrics(); metrics != nil {
-					metrics.IncrementRemoteClusterConnStateChangeCounter(rc.RemoteId, rc.IsOnline())
-				}
-				rcs.fireConnectionStateChgEvent(rc)
-			}
+			rcs.PingNow(rc)
 		case <-done:
 			return
 		}
@@ -103,7 +107,7 @@ var ErrPluginPingFail = errors.New("plugin ping failed")
 func (rcs *Service) pingRemote(rc *model.RemoteCluster) error {
 	ping := model.RemoteClusterPing{}
 
-	if rc.PluginID != "" {
+	if rc.IsPlugin() {
 		ping.SentAt = model.GetMillis()
 		if ok := rcs.app.OnSharedChannelsPing(rc); !ok {
 			return ErrPluginPingFail