From 2385bbdd5033a4d91fd14296731b01172ac2cf20 Mon Sep 17 00:00:00 2001 From: Ashish Bhate Date: Wed, 23 Mar 2022 21:00:53 +0530 Subject: [PATCH] MM-42535: Set ThreadAutoFollow to true by default (#19797) Summary A number of performance improvements shipped in v6.5 to support CRT with the ThreadAutoFollow bookkeeping enabled but the frontend features disabled. To prepare for a later enabling of the frontend features by default, we want to encourage customers to re-enable ThreadAutoFollow, and plan to enable this by default in v6.6. Ticket Link https://mattermost.atlassian.net/browse/MM-42535 --- app/channel_test.go | 3 +++ model/config.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/channel_test.go b/app/channel_test.go index e48837ae6e..0153f723d5 100644 --- a/app/channel_test.go +++ b/app/channel_test.go @@ -2038,6 +2038,9 @@ func TestMarkChannelsAsViewedPanic(t *testing.T) { mockPreferenceStore.On("Get", mock.AnythingOfType("string"), mock.AnythingOfType("string"), mock.AnythingOfType("string")).Return(&model.Preference{Value: "test"}, nil) mockStore.On("Channel").Return(&mockChannelStore) mockStore.On("Preference").Return(&mockPreferenceStore) + mockThreadStore := mocks.ThreadStore{} + mockThreadStore.On("MarkAllAsReadByChannels", "userID", []string{"channelID"}).Return(nil) + mockStore.On("Thread").Return(&mockThreadStore) _, appErr := th.App.MarkChannelsAsViewed([]string{"channelID"}, "userID", th.Context.Session().Id, false) require.Nil(t, appErr) diff --git a/model/config.go b/model/config.go index 1209b36d79..7a37d6b24d 100644 --- a/model/config.go +++ b/model/config.go @@ -781,7 +781,7 @@ func (s *ServiceSettings) SetDefaults(isUpdate bool) { } if s.ThreadAutoFollow == nil { - s.ThreadAutoFollow = NewBool(false) + s.ThreadAutoFollow = NewBool(true) } if s.CollapsedThreads == nil {