[MM-37716] Drop support for LHS specific bot icons (#18087)

app/bot.go

@@ -4,17 +4,11 @@
 package app
 
 import (
-	"bytes"
 	"context"
 	"errors"
 	"fmt"
-	"io"
-	"io/ioutil"
-	"mime/multipart"
 	"net/http"
-	"path/filepath"
 
-	"github.com/mattermost/mattermost-server/v6/app/imaging"
 	"github.com/mattermost/mattermost-server/v6/app/request"
 	"github.com/mattermost/mattermost-server/v6/model"
 	"github.com/mattermost/mattermost-server/v6/shared/i18n"
@@ -571,112 +565,3 @@ func (a *App) ConvertUserToBot(user *model.User) (*model.Bot, *model.AppError) {
 	}
 	return bot, nil
 }
-
-// SetBotIconImageFromMultiPartFile sets LHS icon for a bot.
-func (a *App) SetBotIconImageFromMultiPartFile(botUserId string, imageData *multipart.FileHeader) *model.AppError {
-	file, err := imageData.Open()
-	if err != nil {
-		return model.NewAppError("SetBotIconImage", "api.bot.set_bot_icon_image.open.app_error", nil, err.Error(), http.StatusBadRequest)
-	}
-	defer file.Close()
-
-	file.Seek(0, 0)
-	return a.SetBotIconImage(botUserId, file)
-}
-
-// SetBotIconImage sets LHS icon for a bot.
-func (a *App) SetBotIconImage(botUserId string, file io.ReadSeeker) *model.AppError {
-	bot, err := a.GetBot(botUserId, true)
-	if err != nil {
-		return err
-	}
-
-	if _, err := imaging.ParseSVG(file); err != nil {
-		return model.NewAppError("SetBotIconImage", "api.bot.set_bot_icon_image.parse.app_error", nil, err.Error(), http.StatusBadRequest)
-	}
-
-	file.Seek(0, 0)
-	data, readErr := ioutil.ReadAll(file)
-	if readErr != nil {
-		return model.NewAppError("SetBotIconImage", "api.bot.set_bot_icon_image.read.app_error", nil, readErr.Error(), http.StatusInternalServerError)
-	}
-
-	if storedData, readFileErr := a.ReadFile(getBotIconPath(botUserId)); readFileErr == nil && bytes.Equal(storedData, data) {
-		return nil
-	}
-
-	// Set icon
-	if _, err = a.WriteFile(bytes.NewReader(data), getBotIconPath(botUserId)); err != nil {
-		return model.NewAppError("SetBotIconImage", "api.bot.set_bot_icon_image.app_error", nil, err.Error(), http.StatusInternalServerError)
-	}
-
-	bot.LastIconUpdate = model.GetMillis()
-	if _, err := a.Srv().Store.Bot().Update(bot); err != nil {
-		var nfErr *store.ErrNotFound
-		var appErr *model.AppError
-		switch {
-		case errors.As(err, &nfErr):
-			return model.MakeBotNotFoundError(nfErr.ID)
-		case errors.As(err, &appErr): // in case we haven't converted to plain error.
-			return appErr
-		default: // last fallback in case it doesn't map to an existing app error.
-			return model.NewAppError("SetBotIconImage", "app.bot.patchbot.internal_error", nil, err.Error(), http.StatusInternalServerError)
-		}
-	}
-	a.invalidateUserCacheAndPublish(botUserId)
-
-	return nil
-}
-
-// DeleteBotIconImage deletes LHS icon for a bot.
-func (a *App) DeleteBotIconImage(botUserId string) *model.AppError {
-	bot, err := a.GetBot(botUserId, true)
-	if err != nil {
-		return err
-	}
-
-	// Delete icon
-	if err = a.RemoveFile(getBotIconPath(botUserId)); err != nil {
-		return model.NewAppError("DeleteBotIconImage", "api.bot.delete_bot_icon_image.app_error", nil, err.Error(), http.StatusInternalServerError)
-	}
-
-	if nErr := a.Srv().Store.User().UpdateLastPictureUpdate(botUserId); nErr != nil {
-		mlog.Warn(nErr.Error())
-	}
-
-	bot.LastIconUpdate = int64(0)
-	if _, err := a.Srv().Store.Bot().Update(bot); err != nil {
-		var nfErr *store.ErrNotFound
-		var appErr *model.AppError
-		switch {
-		case errors.As(err, &nfErr):
-			return model.MakeBotNotFoundError(nfErr.ID)
-		case errors.As(err, &appErr): // in case we haven't converted to plain error.
-			return appErr
-		default: // last fallback in case it doesn't map to an existing app error.
-			return model.NewAppError("DeleteBotIconImage", "app.bot.patchbot.internal_error", nil, err.Error(), http.StatusInternalServerError)
-		}
-	}
-
-	a.invalidateUserCacheAndPublish(botUserId)
-
-	return nil
-}
-
-// GetBotIconImage retrieves LHS icon for a bot.
-func (a *App) GetBotIconImage(botUserId string) ([]byte, *model.AppError) {
-	if _, err := a.GetBot(botUserId, true); err != nil {
-		return nil, err
-	}
-
-	data, err := a.ReadFile(getBotIconPath(botUserId))
-	if err != nil {
-		return nil, model.NewAppError("GetBotIconImage", "api.bot.get_bot_icon_image.read.app_error", nil, err.Error(), http.StatusNotFound)
-	}
-
-	return data, nil
-}
-
-func getBotIconPath(botUserId string) string {
-	return filepath.Join("bots", botUserId, "icon.svg")
-}