[MM-37716] Drop support for LHS specific bot icons (#18087)

api4/bot.go

@@ -5,9 +5,6 @@ package api4
 
 import (
 	"encoding/json"
-	"fmt"
-	"io"
-	"io/ioutil"
 	"net/http"
 	"strconv"
 
@@ -25,10 +22,6 @@ func (api *API) InitBot() {
 	api.BaseRoutes.Bot.Handle("/enable", api.ApiSessionRequired(enableBot)).Methods("POST")
 	api.BaseRoutes.Bot.Handle("/convert_to_user", api.ApiSessionRequired(convertBotToUser)).Methods("POST")
 	api.BaseRoutes.Bot.Handle("/assign/{user_id:[A-Za-z0-9]+}", api.ApiSessionRequired(assignBot)).Methods("POST")
-
-	api.BaseRoutes.Bot.Handle("/icon", api.ApiSessionRequiredTrustRequester(getBotIconImage)).Methods("GET")
-	api.BaseRoutes.Bot.Handle("/icon", api.ApiSessionRequired(setBotIconImage)).Methods("POST")
-	api.BaseRoutes.Bot.Handle("/icon", api.ApiSessionRequired(deleteBotIconImage)).Methods("DELETE")
 }
 
 func createBot(c *Context, w http.ResponseWriter, r *http.Request) {
@@ -274,128 +267,6 @@ func assignBot(c *Context, w http.ResponseWriter, _ *http.Request) {
 	}
 }
 
-func getBotIconImage(c *Context, w http.ResponseWriter, r *http.Request) {
-	c.RequireBotUserId()
-	if c.Err != nil {
-		return
-	}
-	botUserId := c.Params.BotUserId
-
-	canSee, err := c.App.UserCanSeeOtherUser(c.AppContext.Session().UserId, botUserId)
-	if err != nil {
-		c.Err = err
-		return
-	}
-
-	if !canSee {
-		c.SetPermissionError(model.PermissionViewMembers)
-		return
-	}
-
-	img, err := c.App.GetBotIconImage(botUserId)
-	if err != nil {
-		c.Err = err
-		return
-	}
-
-	user, err := c.App.GetUser(botUserId)
-	if err != nil {
-		c.Err = err
-		return
-	}
-
-	etag := strconv.FormatInt(user.LastPictureUpdate, 10)
-	if c.HandleEtag(etag, "Get Icon Image", w, r) {
-		return
-	}
-
-	w.Header().Set("Cache-Control", fmt.Sprintf("max-age=%v, private", 24*60*60)) // 24 hrs
-	w.Header().Set(model.HeaderEtagServer, etag)
-	w.Header().Set("Content-Type", "image/svg+xml")
-	w.Write(img)
-}
-
-func setBotIconImage(c *Context, w http.ResponseWriter, r *http.Request) {
-	defer io.Copy(ioutil.Discard, r.Body)
-
-	c.RequireBotUserId()
-	if c.Err != nil {
-		return
-	}
-	botUserId := c.Params.BotUserId
-
-	auditRec := c.MakeAuditRecord("setBotIconImage", audit.Fail)
-	defer c.LogAuditRec(auditRec)
-	auditRec.AddMeta("bot_id", botUserId)
-
-	if err := c.App.SessionHasPermissionToManageBot(*c.AppContext.Session(), botUserId); err != nil {
-		c.Err = err
-		return
-	}
-
-	if r.ContentLength > *c.App.Config().FileSettings.MaxFileSize {
-		c.Err = model.NewAppError("setBotIconImage", "api.bot.set_bot_icon_image.too_large.app_error", nil, "", http.StatusRequestEntityTooLarge)
-		return
-	}
-
-	if err := r.ParseMultipartForm(*c.App.Config().FileSettings.MaxFileSize); err != nil {
-		c.Err = model.NewAppError("setBotIconImage", "api.bot.set_bot_icon_image.parse.app_error", nil, err.Error(), http.StatusInternalServerError)
-		return
-	}
-
-	m := r.MultipartForm
-	imageArray, ok := m.File["image"]
-	if !ok {
-		c.Err = model.NewAppError("setBotIconImage", "api.bot.set_bot_icon_image.no_file.app_error", nil, "", http.StatusBadRequest)
-		return
-	}
-
-	if len(imageArray) <= 0 {
-		c.Err = model.NewAppError("setBotIconImage", "api.bot.set_bot_icon_image.array.app_error", nil, "", http.StatusBadRequest)
-		return
-	}
-
-	imageData := imageArray[0]
-	if err := c.App.SetBotIconImageFromMultiPartFile(botUserId, imageData); err != nil {
-		c.Err = err
-		return
-	}
-
-	auditRec.Success()
-	c.LogAudit("")
-
-	ReturnStatusOK(w)
-}
-
-func deleteBotIconImage(c *Context, w http.ResponseWriter, r *http.Request) {
-	defer io.Copy(ioutil.Discard, r.Body)
-
-	c.RequireBotUserId()
-	if c.Err != nil {
-		return
-	}
-	botUserId := c.Params.BotUserId
-
-	auditRec := c.MakeAuditRecord("deleteBotIconImage", audit.Fail)
-	defer c.LogAuditRec(auditRec)
-	auditRec.AddMeta("bot_id", botUserId)
-
-	if err := c.App.SessionHasPermissionToManageBot(*c.AppContext.Session(), botUserId); err != nil {
-		c.Err = err
-		return
-	}
-
-	if err := c.App.DeleteBotIconImage(botUserId); err != nil {
-		c.Err = err
-		return
-	}
-
-	auditRec.Success()
-	c.LogAudit("")
-
-	ReturnStatusOK(w)
-}
-
 func convertBotToUser(c *Context, w http.ResponseWriter, r *http.Request) {
 	c.RequireBotUserId()
 	if c.Err != nil {