Print panic message when mmctl panics (#27390)

Этот коммит содержится в:
Ben Schumacher
2024-07-02 13:58:37 +02:00
коммит произвёл GitHub
родитель a3c1272cb6
Коммит 213ebc57fb
3 изменённых файлов: 38 добавлений и 7 удалений

Просмотреть файл

@@ -7,8 +7,11 @@ import (
"bytes"
"fmt"
"strings"
"testing"
"github.com/mattermost/mattermost/server/v8/cmd/mmctl/printer"
"github.com/spf13/cobra"
"github.com/stretchr/testify/assert"
)
func executeRawCommand(root *cobra.Command, args string) (c *cobra.Command, output string, err error) {
@@ -20,6 +23,16 @@ func executeRawCommand(root *cobra.Command, args string) (c *cobra.Command, outp
return c, actual.String(), err
}
func TestRootRecover(t *testing.T) {
printPanic("some panic")
lines := printer.GetErrorLines()
assert.Equal(t, "Uh oh! Something unexpected happened :( Would you mind reporting it?", lines[0])
assert.True(t, strings.HasPrefix(lines[1], "https://github.com/mattermost/mattermost/issues/new?body="))
assert.Equal(t, "some panic", lines[2])
assert.True(t, strings.HasPrefix(lines[3], "goroutine "))
}
func (s *MmctlUnitTestSuite) TestArgumentsHaveWhitespaceTrimmed() {
arguments := []string{"value_1", "value_2"}
lineEndings := []string{"\n", "\r", "\r\n"}