From 2117a4ed30590d4b5d4fe8bdceb18613fa72c486 Mon Sep 17 00:00:00 2001 From: Seth Foss Date: Wed, 6 Nov 2024 09:45:56 -0500 Subject: [PATCH] MM-56632 Display warning if requested mage size exceeds max (#26022) (#27216) --- server/cmd/mmctl/commands/root.go | 5 +++++ server/cmd/mmctl/commands/utils.go | 1 + 2 files changed, 6 insertions(+) diff --git a/server/cmd/mmctl/commands/root.go b/server/cmd/mmctl/commands/root.go index bbaedfb27b..4bca116de4 100644 --- a/server/cmd/mmctl/commands/root.go +++ b/server/cmd/mmctl/commands/root.go @@ -108,6 +108,11 @@ var RootCmd = &cobra.Command{ } quiet := viper.GetBool("quiet") printer.SetQuiet(quiet) + + perPage, err := cmd.Flags().GetInt("per-page") + if err == nil && perPage > MaxPageSize { + printer.PrintError(fmt.Sprintf("Per page value is greater than the maximum allowed. Mattermost might only return %d items.", MaxPageSize)) + } }, PersistentPostRun: func(cmd *cobra.Command, args []string) { _ = printer.Flush() diff --git a/server/cmd/mmctl/commands/utils.go b/server/cmd/mmctl/commands/utils.go index 7c7506b27b..db5e3ff457 100644 --- a/server/cmd/mmctl/commands/utils.go +++ b/server/cmd/mmctl/commands/utils.go @@ -16,6 +16,7 @@ import ( const ( DefaultPageSize = 200 + MaxPageSize = 200 ) func checkInteractiveTerminal() error {