[MM-50534] - Renew email adds portal link when not eligible for self-serve renewal (#22350)

* [MM-50534] - Renew email adds portal link when not eligible for self-serve renewal

* fix translations

* make more checks

* improve endpoint to make checks

* use new checks

* fix translations

* fix lint

* add meaningful names

* rename struct

* rename endpoint

api4/cloud_test.go

@@ -650,7 +650,7 @@ func TestGetCloudProducts(t *testing.T) {
 }
 
 func Test_GetExpandStatsForSubscription(t *testing.T) {
-	isExpandable := &model.SubscriptionExpandStatus{
+	status := &model.SubscriptionLicenseSelfServeStatusResponse{
 		IsExpandable: true,
 	}
 
@@ -664,7 +664,7 @@ func Test_GetExpandStatsForSubscription(t *testing.T) {
 
 		cloud := mocks.CloudInterface{}
 
-		cloud.Mock.On("GetLicenseExpandStatus", mock.Anything).Return(isExpandable, nil)
+		cloud.Mock.On("GetLicenseSelfServeStatus", mock.Anything).Return(status, nil)
 
 		cloudImpl := th.App.Srv().Cloud
 		defer func() {
@@ -672,9 +672,9 @@ func Test_GetExpandStatsForSubscription(t *testing.T) {
 		}()
 		th.App.Srv().Cloud = &cloud
 
-		subscriptionExpandable, r, err := th.Client.GetExpandStats(licenseId)
+		checksMade, r, err := th.Client.GetSubscriptionStatus(licenseId)
 		require.Error(t, err)
-		require.Nil(t, subscriptionExpandable)
+		require.Nil(t, checksMade)
 		require.Equal(t, http.StatusForbidden, r.StatusCode, "403 Forbidden")
 	})
 
@@ -686,7 +686,7 @@ func Test_GetExpandStatsForSubscription(t *testing.T) {
 
 		cloud := mocks.CloudInterface{}
 
-		cloud.Mock.On("GetLicenseExpandStatus", mock.Anything).Return(isExpandable, nil)
+		cloud.Mock.On("GetLicenseSelfServeStatus", mock.Anything).Return(status, nil)
 
 		cloudImpl := th.App.Srv().Cloud
 		defer func() {
@@ -694,9 +694,9 @@ func Test_GetExpandStatsForSubscription(t *testing.T) {
 		}()
 		th.App.Srv().Cloud = &cloud
 
-		subscriptionExpandable, r, err := th.Client.GetExpandStats("")
+		checks, r, err := th.Client.GetSubscriptionStatus("")
 		require.Error(t, err)
-		require.Nil(t, subscriptionExpandable)
+		require.Nil(t, checks)
 		require.Equal(t, http.StatusBadRequest, r.StatusCode, "400 Bad Request")
 	})
 }