From 1f26de30242432c2352a9dbaf45d5e52b8ebd65f Mon Sep 17 00:00:00 2001 From: Jesse Hallam Date: Wed, 31 Jul 2024 14:18:30 -0300 Subject: [PATCH] MM-59875: default apps enabled false (#27756) * MM-59875: default apps enabled false We stopped prepackaging the apps framework and stopped supporting it in Mattermost Cloud a year ago. As part of v10, we're formally deprecating it, while making allowances for customers who still need to transition by not making this a breaking change immediately. To help prevent new adoption, let's ensure the feature flag is disabled by default. Fixes: https://mattermost.atlassian.net/browse/MM-59875 * fix tests --- server/channels/app/plugin_test.go | 12 ++++++++++++ server/public/model/feature_flags.go | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/server/channels/app/plugin_test.go b/server/channels/app/plugin_test.go index 8d39b106e9..2f9e83b486 100644 --- a/server/channels/app/plugin_test.go +++ b/server/channels/app/plugin_test.go @@ -1437,6 +1437,18 @@ func TestGetPluginStateOverride(t *testing.T) { t.Run("apps override", func(t *testing.T) { t.Run("without enabled flag", func(t *testing.T) { overrides, value := th.App.ch.getPluginStateOverride("com.mattermost.apps") + require.True(t, overrides) + require.False(t, value) + }) + + t.Run("with enabled flag set to true", func(t *testing.T) { + os.Setenv("MM_FEATUREFLAGS_APPSENABLED", "true") + defer os.Unsetenv("MM_FEATUREFLAGS_APPSENABLED") + + th2 := Setup(t) + defer th2.TearDown() + + overrides, value := th2.App.ch.getPluginStateOverride("com.mattermost.apps") require.False(t, overrides) require.False(t, value) }) diff --git a/server/public/model/feature_flags.go b/server/public/model/feature_flags.go index 8e38ead0c7..b0634f2e24 100644 --- a/server/public/model/feature_flags.go +++ b/server/public/model/feature_flags.go @@ -61,7 +61,7 @@ func (f *FeatureFlags) SetDefaults() { f.TestFeature = "off" f.TestBoolFeature = false f.EnableRemoteClusterService = false - f.AppsEnabled = true + f.AppsEnabled = false f.NormalizeLdapDNs = false f.CallsEnabled = true f.DeprecateCloudFree = false