diff --git a/app/team.go b/app/team.go index d5ac1847e7..008a26bc00 100644 --- a/app/team.go +++ b/app/team.go @@ -631,11 +631,7 @@ func (a *App) GetAllPrivateTeams() ([]*model.Team, *model.AppError) { } func (a *App) GetAllPrivateTeamsPage(offset int, limit int) ([]*model.Team, *model.AppError) { - result := <-a.Srv.Store.Team().GetAllPrivateTeamPageListing(offset, limit) - if result.Err != nil { - return nil, result.Err - } - return result.Data.([]*model.Team), nil + return a.Srv.Store.Team().GetAllPrivateTeamPageListing(offset, limit) } func (a *App) GetAllPublicTeams() ([]*model.Team, *model.AppError) { diff --git a/store/sqlstore/team_store.go b/store/sqlstore/team_store.go index 97d6f35aaa..6ae3eda211 100644 --- a/store/sqlstore/team_store.go +++ b/store/sqlstore/team_store.go @@ -400,22 +400,19 @@ func (s SqlTeamStore) GetAllPrivateTeamListing() store.StoreChannel { }) } -func (s SqlTeamStore) GetAllPrivateTeamPageListing(offset int, limit int) store.StoreChannel { - return store.Do(func(result *store.StoreResult) { - query := "SELECT * FROM Teams WHERE AllowOpenInvite = 0 ORDER BY DisplayName LIMIT :Limit OFFSET :Offset" +func (s SqlTeamStore) GetAllPrivateTeamPageListing(offset int, limit int) ([]*model.Team, *model.AppError) { + query := "SELECT * FROM Teams WHERE AllowOpenInvite = 0 ORDER BY DisplayName LIMIT :Limit OFFSET :Offset" - if s.DriverName() == model.DATABASE_DRIVER_POSTGRES { - query = "SELECT * FROM Teams WHERE AllowOpenInvite = false ORDER BY DisplayName LIMIT :Limit OFFSET :Offset" - } + if s.DriverName() == model.DATABASE_DRIVER_POSTGRES { + query = "SELECT * FROM Teams WHERE AllowOpenInvite = false ORDER BY DisplayName LIMIT :Limit OFFSET :Offset" + } - var data []*model.Team - if _, err := s.GetReplica().Select(&data, query, map[string]interface{}{"Offset": offset, "Limit": limit}); err != nil { - result.Err = model.NewAppError("SqlTeamStore.GetAllPrivateTeamListing", "store.sql_team.get_all_private_team_listing.app_error", nil, err.Error(), http.StatusInternalServerError) - return - } + var data []*model.Team + if _, err := s.GetReplica().Select(&data, query, map[string]interface{}{"Offset": offset, "Limit": limit}); err != nil { + return nil, model.NewAppError("SqlTeamStore.GetAllPrivateTeamListing", "store.sql_team.get_all_private_team_listing.app_error", nil, err.Error(), http.StatusInternalServerError) + } - result.Data = data - }) + return data, nil } func (s SqlTeamStore) GetAllTeamListing() store.StoreChannel { diff --git a/store/store.go b/store/store.go index e050ae0e21..efb0edea53 100644 --- a/store/store.go +++ b/store/store.go @@ -93,7 +93,7 @@ type TeamStore interface { GetAll() ([]*model.Team, *model.AppError) GetAllPage(offset int, limit int) StoreChannel GetAllPrivateTeamListing() StoreChannel - GetAllPrivateTeamPageListing(offset int, limit int) StoreChannel + GetAllPrivateTeamPageListing(offset int, limit int) ([]*model.Team, *model.AppError) GetAllTeamListing() StoreChannel GetAllTeamPageListing(offset int, limit int) StoreChannel GetTeamsByUserId(userId string) StoreChannel diff --git a/store/storetest/mocks/TeamStore.go b/store/storetest/mocks/TeamStore.go index f48e473f34..493ee75617 100644 --- a/store/storetest/mocks/TeamStore.go +++ b/store/storetest/mocks/TeamStore.go @@ -181,19 +181,28 @@ func (_m *TeamStore) GetAllPrivateTeamListing() store.StoreChannel { } // GetAllPrivateTeamPageListing provides a mock function with given fields: offset, limit -func (_m *TeamStore) GetAllPrivateTeamPageListing(offset int, limit int) store.StoreChannel { +func (_m *TeamStore) GetAllPrivateTeamPageListing(offset int, limit int) ([]*model.Team, *model.AppError) { ret := _m.Called(offset, limit) - var r0 store.StoreChannel - if rf, ok := ret.Get(0).(func(int, int) store.StoreChannel); ok { + var r0 []*model.Team + if rf, ok := ret.Get(0).(func(int, int) []*model.Team); ok { r0 = rf(offset, limit) } else { if ret.Get(0) != nil { - r0 = ret.Get(0).(store.StoreChannel) + r0 = ret.Get(0).([]*model.Team) } } - return r0 + var r1 *model.AppError + if rf, ok := ret.Get(1).(func(int, int) *model.AppError); ok { + r1 = rf(offset, limit) + } else { + if ret.Get(1) != nil { + r1 = ret.Get(1).(*model.AppError) + } + } + + return r0, r1 } // GetAllTeamListing provides a mock function with given fields: diff --git a/store/storetest/team_store.go b/store/storetest/team_store.go index f769a42840..5d2d689a5c 100644 --- a/store/storetest/team_store.go +++ b/store/storetest/team_store.go @@ -683,11 +683,9 @@ func testGetAllPrivateTeamPageListing(t *testing.T, ss store.Store) { _, err = ss.Team().Save(&o4) require.Nil(t, err) - if r1 := <-ss.Team().GetAllPrivateTeamPageListing(0, 10); r1.Err != nil { - t.Fatal(r1.Err) + if teams, listErr := ss.Team().GetAllPrivateTeamPageListing(0, 10); listErr != nil { + t.Fatal(listErr) } else { - teams := r1.Data.([]*model.Team) - for _, team := range teams { if team.AllowOpenInvite { t.Fatal("should have returned team with AllowOpenInvite as false") @@ -708,11 +706,9 @@ func testGetAllPrivateTeamPageListing(t *testing.T, ss store.Store) { _, err = ss.Team().Save(&o5) require.Nil(t, err) - if r1 := <-ss.Team().GetAllPrivateTeamPageListing(0, 4); r1.Err != nil { - t.Fatal(r1.Err) + if teams, listErr := ss.Team().GetAllPrivateTeamPageListing(0, 4); listErr != nil { + t.Fatal(listErr) } else { - teams := r1.Data.([]*model.Team) - for _, team := range teams { if team.AllowOpenInvite { t.Fatal("should have returned team with AllowOpenInvite as false") @@ -724,11 +720,9 @@ func testGetAllPrivateTeamPageListing(t *testing.T, ss store.Store) { } } - if r1 := <-ss.Team().GetAllPrivateTeamPageListing(1, 1); r1.Err != nil { - t.Fatal(r1.Err) + if teams, listErr := ss.Team().GetAllPrivateTeamPageListing(1, 1); listErr != nil { + t.Fatal(listErr) } else { - teams := r1.Data.([]*model.Team) - for _, team := range teams { if team.AllowOpenInvite { t.Fatal("should have returned team with AllowOpenInvite as false")