MM-14143 config cleanup final (#10374)

* TestGetLicenseFileFromDisk: avoid using fileutils.FindConfigFile

* config: abstract config-related file access, extend memory store

* simplify config validate to avoid file knowledge

* fix relative file tests

* cluster: fix ConfigChanged event

The old and new configurations were swapped when notifying the enterprise code of configuration changes, creating needless instability in propagating config updates across a cluster.

* config/database: ignore duplicates

* test cleanup

* remove unnecessary Save() in test

config/common_test.go

@@ -6,6 +6,71 @@ import (
 	"github.com/mattermost/mattermost-server/model"
 )
 
+var emptyConfig, readOnlyConfig, minimalConfig, invalidConfig, fixesRequiredConfig, ldapConfig, testConfig *model.Config
+
+func init() {
+	emptyConfig = &model.Config{}
+	readOnlyConfig = &model.Config{
+		ClusterSettings: model.ClusterSettings{
+			Enable:         bToP(true),
+			ReadOnlyConfig: bToP(true),
+		},
+	}
+	minimalConfig = &model.Config{
+		ServiceSettings: model.ServiceSettings{
+			SiteURL: sToP("http://minimal"),
+		},
+		SqlSettings: model.SqlSettings{
+			AtRestEncryptKey: sToP("abcdefghijklmnopqrstuvwxyz0123456789"),
+		},
+		FileSettings: model.FileSettings{
+			PublicLinkSalt: sToP("abcdefghijklmnopqrstuvwxyz0123456789"),
+		},
+		EmailSettings: model.EmailSettings{
+			InviteSalt: sToP("abcdefghijklmnopqrstuvwxyz0123456789"),
+		},
+		LocalizationSettings: model.LocalizationSettings{
+			DefaultServerLocale: sToP("en"),
+			DefaultClientLocale: sToP("en"),
+		},
+	}
+	invalidConfig = &model.Config{
+		ServiceSettings: model.ServiceSettings{
+			SiteURL: sToP("invalid"),
+		},
+	}
+	fixesRequiredConfig = &model.Config{
+		ServiceSettings: model.ServiceSettings{
+			SiteURL: sToP("http://trailingslash/"),
+		},
+		SqlSettings: model.SqlSettings{
+			AtRestEncryptKey: sToP("abcdefghijklmnopqrstuvwxyz0123456789"),
+		},
+		FileSettings: model.FileSettings{
+			DriverName:     sToP(model.IMAGE_DRIVER_LOCAL),
+			Directory:      sToP("/path/to/directory"),
+			PublicLinkSalt: sToP("abcdefghijklmnopqrstuvwxyz0123456789"),
+		},
+		EmailSettings: model.EmailSettings{
+			InviteSalt: sToP("abcdefghijklmnopqrstuvwxyz0123456789"),
+		},
+		LocalizationSettings: model.LocalizationSettings{
+			DefaultServerLocale: sToP("garbage"),
+			DefaultClientLocale: sToP("garbage"),
+		},
+	}
+	ldapConfig = &model.Config{
+		LdapSettings: model.LdapSettings{
+			BindPassword: sToP("password"),
+		},
+	}
+	testConfig = &model.Config{
+		ServiceSettings: model.ServiceSettings{
+			SiteURL: sToP("http://TestStoreNew"),
+		},
+	}
+}
+
 func prepareExpectedConfig(t *testing.T, expectedCfg *model.Config) *model.Config {
 	// These fields require special initialization for our tests.
 	expectedCfg = expectedCfg.Clone()