From 1cf6cf4f5c135bc8799b79109511edd4ef5370c2 Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Fri, 9 Aug 2024 22:24:18 +0530 Subject: [PATCH] MM-59940: Pin govet version to a SHA version (#27885) https://mattermost.atlassian.net/browse/MM-59940 ```release-note NONE ``` --- server/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/server/Makefile b/server/Makefile index 880d951fd3..0d58a039d5 100644 --- a/server/Makefile +++ b/server/Makefile @@ -748,7 +748,9 @@ ifeq ($(BUILD_ENTERPRISE_READY),true) endif vet: ## Run mattermost go vet specific checks - $(GO) install github.com/mattermost/mattermost-govet/v2@new + ## Note that it is pinned to a specific commit, rather than a branch. This is to prevent + ## having to backport the fix to multiple release branches for any new change. + $(GO) install github.com/mattermost/mattermost-govet/v2@72e7752bcf59b57688fcb41173a6a1583c405adf $(GO) vet -vettool=$(GOBIN)/mattermost-govet -structuredLogging -inconsistentReceiverName -emptyStrCmp -tFatal -configtelemetry -errorAssertions -license -inconsistentReceiverName.ignore=session_serial_gen.go,team_member_serial_gen.go,user_serial_gen.go ./... ifeq ($(BUILD_ENTERPRISE_READY),true) ifneq ($(MM_NO_ENTERPRISE_LINT),true) @@ -760,7 +762,7 @@ vet-api: export GO := $(GO) vet-api: export GOBIN := $(GOBIN) vet-api: export ROOT := $(ROOT) vet-api: ## Run mattermost go vet to verify api4 documentation, currently not passing - $(GO) install github.com/mattermost/mattermost-govet/v2@new + $(GO) install github.com/mattermost/mattermost-govet/v2@72e7752bcf59b57688fcb41173a6a1583c405adf make -C ../api build ./scripts/vet-api-check.sh