From 1cc50ff90c10bb5b506534fdcda54f20ccbe662b Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Mon, 4 Apr 2022 10:27:29 +0530 Subject: [PATCH] api4/license: Return 400 instead of 501 if format is not passed (#19856) ```release-note NONE ``` Co-authored-by: Mattermod --- api4/license.go | 2 +- api4/license_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/api4/license.go b/api4/license.go index 2a6b61c916..f6ad9efd19 100644 --- a/api4/license.go +++ b/api4/license.go @@ -31,7 +31,7 @@ func getClientLicense(c *Context, w http.ResponseWriter, r *http.Request) { format := r.URL.Query().Get("format") if format == "" { - c.Err = model.NewAppError("getClientLicense", "api.license.client.old_format.app_error", nil, "", http.StatusNotImplemented) + c.Err = model.NewAppError("getClientLicense", "api.license.client.old_format.app_error", nil, "", http.StatusBadRequest) return } diff --git a/api4/license_test.go b/api4/license_test.go index 5d3c04ec71..4e61cfdf6e 100644 --- a/api4/license_test.go +++ b/api4/license_test.go @@ -38,8 +38,8 @@ func TestGetOldClientLicense(t *testing.T) { resp, err := client.DoAPIGet("/license/client", "") require.Error(t, err, "get /license/client did not return an error") - require.Equal(t, http.StatusNotImplemented, resp.StatusCode, - "expected 501 Not Implemented") + require.Equal(t, http.StatusBadRequest, resp.StatusCode, + "expected 400 bad request") resp, err = client.DoAPIGet("/license/client?format=junk", "") require.Error(t, err, "get /license/client?format=junk did not return an error")