diff --git a/app/team.go b/app/team.go index dba591ed6d..a44c88c614 100644 --- a/app/team.go +++ b/app/team.go @@ -664,11 +664,7 @@ func (a *App) SearchPublicTeams(term string) ([]*model.Team, *model.AppError) { } func (a *App) SearchPrivateTeams(term string) ([]*model.Team, *model.AppError) { - result := <-a.Srv.Store.Team().SearchPrivate(term) - if result.Err != nil { - return nil, result.Err - } - return result.Data.([]*model.Team), nil + return a.Srv.Store.Team().SearchPrivate(term) } func (a *App) GetTeamsForUser(userId string) ([]*model.Team, *model.AppError) { diff --git a/output b/output deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/store/sqlstore/team_store.go b/store/sqlstore/team_store.go index 692236dc9e..45a9d30fc4 100644 --- a/store/sqlstore/team_store.go +++ b/store/sqlstore/team_store.go @@ -335,17 +335,20 @@ func (s SqlTeamStore) SearchOpen(term string) store.StoreChannel { }) } -func (s SqlTeamStore) SearchPrivate(term string) store.StoreChannel { - return store.Do(func(result *store.StoreResult) { - var teams []*model.Team +func (s SqlTeamStore) SearchPrivate(term string) ([]*model.Team, *model.AppError) { + var teams []*model.Team - if _, err := s.GetReplica().Select(&teams, "SELECT * FROM Teams WHERE (Type != 'O' OR AllowOpenInvite = false) AND (Name LIKE :Term OR DisplayName LIKE :Term)", map[string]interface{}{"Term": term + "%"}); err != nil { - result.Err = model.NewAppError("SqlTeamStore.SearchPrivate", "store.sql_team.search_private_team.app_error", nil, "term="+term+", "+err.Error(), http.StatusInternalServerError) - return - } - - result.Data = teams - }) + query := + `SELECT * + FROM + Teams + WHERE + (Type != 'O' OR AllowOpenInvite = false) AND + (Name LIKE :Term OR DisplayName LIKE :Term)` + if _, err := s.GetReplica().Select(&teams, query, map[string]interface{}{"Term": term + "%"}); err != nil { + return nil, model.NewAppError("SqlTeamStore.SearchPrivate", "store.sql_team.search_private_team.app_error", nil, "term="+term+", "+err.Error(), http.StatusInternalServerError) + } + return teams, nil } func (s SqlTeamStore) GetAll() ([]*model.Team, *model.AppError) { diff --git a/store/store.go b/store/store.go index e01bd58aa5..8572134f04 100644 --- a/store/store.go +++ b/store/store.go @@ -89,7 +89,7 @@ type TeamStore interface { SearchByName(name string) ([]*model.Team, *model.AppError) SearchAll(term string) StoreChannel SearchOpen(term string) StoreChannel - SearchPrivate(term string) StoreChannel + SearchPrivate(term string) ([]*model.Team, *model.AppError) GetAll() ([]*model.Team, *model.AppError) GetAllPage(offset int, limit int) StoreChannel GetAllPrivateTeamListing() StoreChannel diff --git a/store/storetest/mocks/TeamStore.go b/store/storetest/mocks/TeamStore.go index 6b0e4485f5..41faeb2e77 100644 --- a/store/storetest/mocks/TeamStore.go +++ b/store/storetest/mocks/TeamStore.go @@ -729,19 +729,28 @@ func (_m *TeamStore) SearchOpen(term string) store.StoreChannel { } // SearchPrivate provides a mock function with given fields: term -func (_m *TeamStore) SearchPrivate(term string) store.StoreChannel { +func (_m *TeamStore) SearchPrivate(term string) ([]*model.Team, *model.AppError) { ret := _m.Called(term) - var r0 store.StoreChannel - if rf, ok := ret.Get(0).(func(string) store.StoreChannel); ok { + var r0 []*model.Team + if rf, ok := ret.Get(0).(func(string) []*model.Team); ok { r0 = rf(term) } else { if ret.Get(0) != nil { - r0 = ret.Get(0).(store.StoreChannel) + r0 = ret.Get(0).([]*model.Team) } } - return r0 + var r1 *model.AppError + if rf, ok := ret.Get(1).(func(string) *model.AppError); ok { + r1 = rf(term) + } else { + if ret.Get(1) != nil { + r1 = ret.Get(1).(*model.AppError) + } + } + + return r0, r1 } // Update provides a mock function with given fields: team diff --git a/store/storetest/team_store.go b/store/storetest/team_store.go index f0e87a2510..13fcc772c1 100644 --- a/store/storetest/team_store.go +++ b/store/storetest/team_store.go @@ -376,9 +376,9 @@ func testTeamStoreSearchPrivate(t *testing.T, ss store.Store) { for _, tc := range testCases { t.Run(tc.Name, func(t *testing.T) { - r1 := <-ss.Team().SearchPrivate(tc.Term) - require.Nil(t, r1.Err) - results := r1.Data.([]*model.Team) + r1, err := ss.Team().SearchPrivate(tc.Term) + require.Nil(t, err) + results := r1 require.Equal(t, tc.ExpectedLenth, len(results)) if tc.ExpectedFirstId != "" { assert.Equal(t, tc.ExpectedFirstId, results[0].Id)