From 1a095f74c2b279761fea3bbd13e6efe8ab274765 Mon Sep 17 00:00:00 2001 From: molejnik88 Date: Wed, 20 Nov 2024 10:40:05 +0100 Subject: [PATCH] =?UTF-8?q?[MM-61459]=20Fix=20errcheck=20issues=20in=20ser?= =?UTF-8?q?ver/channels/app/plugin=5Fsignatur=E2=80=A6=20(#29202)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- server/.golangci.yml | 1 - server/channels/app/plugin_signature.go | 10 ++++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index f4ef50f35f..04e01aac88 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -118,7 +118,6 @@ issues: channels/app/platform/web_hub.go|\ channels/app/platform/web_hub_test.go|\ channels/app/plugin_install.go|\ - channels/app/plugin_signature.go|\ channels/app/plugin_signature_test.go|\ channels/app/plugin_test.go|\ channels/app/post.go|\ diff --git a/server/channels/app/plugin_signature.go b/server/channels/app/plugin_signature.go index 9c1549fca6..bb69d52b5b 100644 --- a/server/channels/app/plugin_signature.go +++ b/server/channels/app/plugin_signature.go @@ -90,8 +90,14 @@ func (ch *Channels) verifyPlugin(plugin, signature io.ReadSeeker) *model.AppErro continue } publicKey := bytes.NewReader(pkBytes) - plugin.Seek(0, 0) - signature.Seek(0, 0) + if _, err := plugin.Seek(0, io.SeekStart); err != nil { + mlog.Warn("Unable to seek in public key reader for ", mlog.String("filename", pk)) + continue + } + if _, err := signature.Seek(0, io.SeekStart); err != nil { + mlog.Warn("Unable to seek in signature for public key ", mlog.String("filename", pk)) + continue + } if err := verifySignature(publicKey, plugin, signature); err == nil { return nil }