From 18388a8c6439121aeac22be76618c2a6e839f16a Mon Sep 17 00:00:00 2001 From: Rohan Sharma <117426013+RS-labhub@users.noreply.github.com> Date: Mon, 7 Oct 2024 16:16:00 +0530 Subject: [PATCH] fix: shared channel errcheck issues (#28542) --- server/.golangci.yml | 1 - server/channels/api4/shared_channel.go | 8 ++++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index 57dcd1ce8d..261401ca25 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -101,7 +101,6 @@ issues: channels/api4/saml.go|\ channels/api4/scheme.go|\ channels/api4/scheme_test.go|\ - channels/api4/shared_channel.go|\ channels/api4/shared_channel_test.go|\ channels/api4/status.go|\ channels/api4/status_test.go|\ diff --git a/server/channels/api4/shared_channel.go b/server/channels/api4/shared_channel.go index 8fd1c0859f..c2a89cb3cf 100644 --- a/server/channels/api4/shared_channel.go +++ b/server/channels/api4/shared_channel.go @@ -60,7 +60,9 @@ func getSharedChannels(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(b) + if _, err := w.Write(b); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func getRemoteClusterInfo(c *Context, w http.ResponseWriter, r *http.Request) { @@ -90,7 +92,9 @@ func getRemoteClusterInfo(c *Context, w http.ResponseWriter, r *http.Request) { c.SetJSONEncodingError(err) return } - w.Write(b) + if _, err := w.Write(b); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func getSharedChannelRemotesByRemoteCluster(c *Context, w http.ResponseWriter, r *http.Request) {