Fix shadowed variables in various places: Part 2 of 2 (#10176)

This PR fixes shadowed variables in the following packages:
- `app`
- `utils`
- `utils/markdown`
- `services/mailservice`

utils/markdown/blocks.go

@@ -77,10 +77,10 @@ func ParseBlocks(markdown string, lines []Line) (*Document, []*ReferenceDefiniti
 				didAdd := false
 				for i := lastMatchIndex; i >= 0; i-- {
 					if container, ok := openBlocks[i].(ContainerBlock); ok {
-						if newBlocks := container.AddChild(newBlocks); newBlocks != nil {
+						if addedBlocks := container.AddChild(newBlocks); addedBlocks != nil {
 							closeBlocks(openBlocks[i+1:], &referenceDefinitions)
 							openBlocks = openBlocks[:i+1]
-							openBlocks = append(openBlocks, newBlocks...)
+							openBlocks = append(openBlocks, addedBlocks...)
 							didAdd = true
 							break
 						}

utils/markdown/inlines.go

@@ -398,8 +398,8 @@ func (p *inlineParser) lookForLinkOrImage() {
 				p.inlines = append(p.inlines[:d.TextNode], inline)
 			} else {
 				p.inlines = append(p.inlines[:d.TextNode], inline)
-				for element := element.Prev(); element != nil; element = element.Prev() {
-					if d := element.Value.(*delimiter); d.Type == linkOpeningDelimiter {
+				for inlineElement := element.Prev(); inlineElement != nil; inlineElement = inlineElement.Prev() {
+					if d := inlineElement.Value.(*delimiter); d.Type == linkOpeningDelimiter {
 						d.IsInactive = true
 					}
 				}