diff --git a/app/permissions.go b/app/permissions.go index 287e863001..01ab3e7849 100644 --- a/app/permissions.go +++ b/app/permissions.go @@ -18,8 +18,8 @@ const systemSchemeName = "00000000-0000-0000-0000-000000000000" // Prevents coll func (a *App) ResetPermissionsSystem() *model.AppError { // Reset all Teams to not have a scheme. - if result := <-a.Srv.Store.Team().ResetAllTeamSchemes(); result.Err != nil { - return result.Err + if err := a.Srv.Store.Team().ResetAllTeamSchemes(); err != nil { + return err } // Reset all Channels to not have a scheme. diff --git a/store/sqlstore/team_store.go b/store/sqlstore/team_store.go index 49f86b1867..ca1a47a179 100644 --- a/store/sqlstore/team_store.go +++ b/store/sqlstore/team_store.go @@ -876,12 +876,11 @@ func (s SqlTeamStore) MigrateTeamMembers(fromTeamId string, fromUserId string) s }) } -func (s SqlTeamStore) ResetAllTeamSchemes() store.StoreChannel { - return store.Do(func(result *store.StoreResult) { - if _, err := s.GetMaster().Exec("UPDATE Teams SET SchemeId=''"); err != nil { - result.Err = model.NewAppError("SqlTeamStore.ResetAllTeamSchemes", "store.sql_team.reset_all_team_schemes.app_error", nil, err.Error(), http.StatusInternalServerError) - } - }) +func (s SqlTeamStore) ResetAllTeamSchemes() *model.AppError { + if _, err := s.GetMaster().Exec("UPDATE Teams SET SchemeId=''"); err != nil { + return model.NewAppError("SqlTeamStore.ResetAllTeamSchemes", "store.sql_team.reset_all_team_schemes.app_error", nil, err.Error(), http.StatusInternalServerError) + } + return nil } var allTeamIdsForUserCache = utils.NewLru(ALL_TEAM_IDS_FOR_USER_CACHE_SIZE) diff --git a/store/store.go b/store/store.go index 6183079ef9..34d48bb318 100644 --- a/store/store.go +++ b/store/store.go @@ -117,7 +117,7 @@ type TeamStore interface { UpdateLastTeamIconUpdate(teamId string, curTime int64) *model.AppError GetTeamsByScheme(schemeId string, offset int, limit int) ([]*model.Team, *model.AppError) MigrateTeamMembers(fromTeamId string, fromUserId string) StoreChannel - ResetAllTeamSchemes() StoreChannel + ResetAllTeamSchemes() *model.AppError ClearAllCustomRoleAssignments() StoreChannel AnalyticsGetTeamCountForScheme(schemeId string) StoreChannel GetAllForExportAfter(limit int, afterId string) ([]*model.TeamForExport, *model.AppError) diff --git a/store/storetest/mocks/TeamStore.go b/store/storetest/mocks/TeamStore.go index 0de134487d..6caaf36fa1 100644 --- a/store/storetest/mocks/TeamStore.go +++ b/store/storetest/mocks/TeamStore.go @@ -712,15 +712,15 @@ func (_m *TeamStore) RemoveMember(teamId string, userId string) store.StoreChann } // ResetAllTeamSchemes provides a mock function with given fields: -func (_m *TeamStore) ResetAllTeamSchemes() store.StoreChannel { +func (_m *TeamStore) ResetAllTeamSchemes() *model.AppError { ret := _m.Called() - var r0 store.StoreChannel - if rf, ok := ret.Get(0).(func() store.StoreChannel); ok { + var r0 *model.AppError + if rf, ok := ret.Get(0).(func() *model.AppError); ok { r0 = rf() } else { if ret.Get(0) != nil { - r0 = ret.Get(0).(store.StoreChannel) + r0 = ret.Get(0).(*model.AppError) } } diff --git a/store/storetest/team_store.go b/store/storetest/team_store.go index fb2ee1620d..ac6f17b11b 100644 --- a/store/storetest/team_store.go +++ b/store/storetest/team_store.go @@ -1480,8 +1480,8 @@ func testResetAllTeamSchemes(t *testing.T, ss store.Store) { assert.Equal(t, s1.Id, *t1.SchemeId) assert.Equal(t, s1.Id, *t2.SchemeId) - res := <-ss.Team().ResetAllTeamSchemes() - assert.Nil(t, res.Err) + res := ss.Team().ResetAllTeamSchemes() + assert.Nil(t, res) t1, err = ss.Team().Get(t1.Id) require.Nil(t, err)