diff --git a/server/channels/app/server.go b/server/channels/app/server.go index c6222afc2a..a70eca0459 100644 --- a/server/channels/app/server.go +++ b/server/channels/app/server.go @@ -462,12 +462,12 @@ func NewServer(options ...Option) (*Server, error) { // if enabled - perform initial product notices fetch if *s.platform.Config().AnnouncementSettings.AdminNoticesEnabled || *s.platform.Config().AnnouncementSettings.UserNoticesEnabled { - go func() { + s.platform.Go(func() { appInstance := New(ServerConnector(s.Channels())) if err := appInstance.UpdateProductNotices(); err != nil { mlog.Warn("Failed to perform initial product notices fetch", mlog.Err(err)) } - }() + }) } if s.skipPostInit { diff --git a/server/channels/app/server_test.go b/server/channels/app/server_test.go index a816c54de7..ec08ddd1ad 100644 --- a/server/channels/app/server_test.go +++ b/server/channels/app/server_test.go @@ -42,6 +42,8 @@ func newServerWithConfig(t *testing.T, f func(cfg *model.Config)) (*Server, erro store, err := config.NewStoreFromBacking(configStore, nil, false) require.NoError(t, err) cfg := store.Get() + *cfg.AnnouncementSettings.AdminNoticesEnabled = false + *cfg.AnnouncementSettings.UserNoticesEnabled = false cfg.SqlSettings = *mainHelper.GetSQLSettings() f(cfg) @@ -110,6 +112,8 @@ func TestStartServerNoS3Bucket(t *testing.T) { AmazonS3SSL: model.NewBool(false), } *cfg.ServiceSettings.ListenAddress = "localhost:0" + *cfg.AnnouncementSettings.AdminNoticesEnabled = false + *cfg.AnnouncementSettings.UserNoticesEnabled = false cfg.SqlSettings = *mainHelper.GetSQLSettings() _, _, err := store.Set(cfg) require.NoError(t, err) @@ -191,6 +195,8 @@ func TestStartServerTLSVersion(t *testing.T) { cfg := store.Get() testDir, _ := fileutils.FindDir("tests") + *cfg.AnnouncementSettings.AdminNoticesEnabled = false + *cfg.AnnouncementSettings.UserNoticesEnabled = false *cfg.ServiceSettings.ListenAddress = "localhost:0" *cfg.ServiceSettings.ConnectionSecurity = "TLS" *cfg.ServiceSettings.TLSMinVer = "1.2"