Pre-package Calls v0.6.0 and enable it by default (#20388)

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

app/plugin.go

@@ -1121,8 +1121,8 @@ func (ch *Channels) getPluginStateOverride(pluginID string) (bool, bool) {
 			return true, false
 		}
 	case model.PluginIdCalls:
-		if model.IsCloud() {
-			return true, ch.cfgSvc.Config().FeatureFlags.CallsEnabled
+		if !ch.cfgSvc.Config().FeatureFlags.CallsEnabled {
+			return true, false
 		}
 	}
 

app/plugin_test.go

@@ -1053,7 +1053,7 @@ func TestGetPluginStateOverride(t *testing.T) {
 			os.Setenv("MM_CLOUD_INSTALLATION_ID", "test")
 			defer os.Unsetenv("MM_CLOUD_INSTALLATION_ID")
 			overrides, value := th.App.ch.getPluginStateOverride("com.mattermost.calls")
-			require.True(t, overrides)
+			require.False(t, overrides)
 			require.False(t, value)
 		})
 
@@ -1067,8 +1067,8 @@ func TestGetPluginStateOverride(t *testing.T) {
 			defer th2.TearDown()
 
 			overrides, value := th2.App.ch.getPluginStateOverride("com.mattermost.calls")
-			require.True(t, overrides)
-			require.True(t, value)
+			require.False(t, overrides)
+			require.False(t, value)
 		})
 
 		t.Run("Cloud, with enabled flag set to false", func(t *testing.T) {
@@ -1084,6 +1084,18 @@ func TestGetPluginStateOverride(t *testing.T) {
 			require.True(t, overrides)
 			require.False(t, value)
 		})
+
+		t.Run("On-prem, with enabled flag set to false", func(t *testing.T) {
+			os.Setenv("MM_FEATUREFLAGS_CALLSENABLED", "false")
+			defer os.Unsetenv("MM_FEATUREFLAGS_CALLSENABLED")
+
+			th2 := Setup(t)
+			defer th2.TearDown()
+
+			overrides, value := th2.App.ch.getPluginStateOverride("com.mattermost.calls")
+			require.True(t, overrides)
+			require.False(t, value)
+		})
 	})
 
 	t.Run("apps override", func(t *testing.T) {