MM-54569 : Update maximum password length on UI to 72 characters (#26699)

server/channels/app/users/password.go

@@ -48,8 +48,14 @@ func IsPasswordValidWithSettings(password string, settings *model.PasswordSettin
 	id := "model.user.is_valid.pwd"
 	isError := false
 
-	if len(password) < *settings.MinimumLength || len(password) > model.PasswordMaximumLength {
+	if len(password) < *settings.MinimumLength {
 		isError = true
+		id = id + "_min_length"
+	}
+
+	if len(password) > model.PasswordMaximumLength {
+		isError = true
+		id = id + "_max_length"
 	}
 
 	if *settings.Lowercase {

server/channels/app/users/password_test.go

@@ -54,7 +54,7 @@ func TestIsPasswordValidWithSettings(t *testing.T) {
 				Number:        model.NewBool(false),
 				Symbol:        model.NewBool(false),
 			},
-			ExpectedError: "model.user.is_valid.pwd.app_error",
+			ExpectedError: "model.user.is_valid.pwd_min_length.app_error",
 		},
 		"TooLong": {
 			Password: strings.Repeat("x", model.PasswordMaximumLength+1),
@@ -64,7 +64,7 @@ func TestIsPasswordValidWithSettings(t *testing.T) {
 				Number:    model.NewBool(false),
 				Symbol:    model.NewBool(false),
 			},
-			ExpectedError: "model.user.is_valid.pwd.app_error",
+			ExpectedError: "model.user.is_valid.pwd_max_length.app_error",
 		},
 		"MissingLower": {
 			Password: "AAAAAAAAAAASD123!@#",

server/i18n/en.json

@@ -10018,10 +10018,6 @@
     "id": "model.user.is_valid.position.app_error",
     "translation": "Invalid position: must not be longer than 128 characters."
   },
-  {
-    "id": "model.user.is_valid.pwd.app_error",
-    "translation": "Your password must contain at least {{.Min}} characters."
-  },
   {
     "id": "model.user.is_valid.pwd_lowercase.app_error",
     "translation": "Your password must contain at least {{.Min}} characters made up of at least one lowercase letter."
@@ -10054,6 +10050,14 @@
     "id": "model.user.is_valid.pwd_lowercase_uppercase_symbol.app_error",
     "translation": "Your password must contain at least {{.Min}} characters made up of at least one lowercase letter, at least one uppercase letter, and at least one symbol (e.g. \"~!@#$%^&*()\")."
   },
+  {
+    "id": "model.user.is_valid.pwd_max_length.app_error",
+    "translation": "Your password must contain no more than 72 characters."
+  },
+  {
+    "id": "model.user.is_valid.pwd_min_length.app_error",
+    "translation": "Your password must contain at least {{.Min}} characters."
+  },
   {
     "id": "model.user.is_valid.pwd_number.app_error",
     "translation": "Your password must contain at least {{.Min}} characters made up of at least one number."

server/public/model/config.go

@@ -43,7 +43,7 @@ const (
 	MinioSecretKey = "miniosecretkey"
 	MinioBucket    = "mattermost-test"
 
-	PasswordMaximumLength = 64
+	PasswordMaximumLength = 72
 	PasswordMinimumLength = 5
 
 	ServiceGitlab    = "gitlab"