mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность

MM-64725 - channel settings modal do not update url automatically (#33500) (#35052)

Просмотр исходного кода 
Automatic Merge
Этот коммит содержится в:
Mattermost Build
2026-01-26 11:53:39 +02:00
коммит произвёл GitHub
родитель 4b8b1e5ca0
Коммит 12dce033d6
6 изменённых файлов: 121 добавлений и 9 удалений
Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

99
e2e-tests/cypress/tests/integration/channels/channel/channel_settings_modal_spec.ts
Просмотреть файл

@@ -95,8 +95,10 @@ describe('Channel Settings Modal', () => {
// # Edit channel name
cy.get('#input_channel-settings-name').clear().type('Updated Channel Name');
// * Verify URL is updated automatically
cy.get('.url-input-label').should('contain', 'updated-channel-name');
// * Verify URL remains unchanged (does not auto-update when editing existing channels)
cy.get('@originalUrl').then((originalUrl) => {
cy.get('.url-input-label').should('contain', originalUrl);
});
// # Click Save
cy.get('[data-testid="SaveChangesPanel__save-btn"]').click();
@@ -135,6 +137,99 @@ describe('Channel Settings Modal', () => {
cy.get('#channelHeaderTitle').should('contain', originalTestChannel.display_name);
});
it('MM-T31: Channel name changes do not auto-update URL, URL only changes when explicitly modified', () => {
// # Create a new channel for this test
cy.apiCreateChannel(testTeam.id, 'url-behavior-test', 'URL Behavior Test').then(({channel}) => {
cy.visit(`/${testTeam.name}/channels/${channel.name}`);
// # Open channel settings modal
cy.get('#channelHeaderDropdownButton').click();
cy.findByText('Channel Settings').click();
// # Store original values
cy.get('#input_channel-settings-name').invoke('val').as('originalName');
cy.get('.url-input-label').invoke('val').as('originalUrl');
// # Verify changing channel name does NOT auto-update URL
// # Change the channel name
cy.get('#input_channel-settings-name').clear().type('New Channel Name');
// * Verify URL remains unchanged after name change
cy.get('@originalUrl').then((originalUrl) => {
cy.get('.url-input-label').should('contain', originalUrl);
});
// # Save the name change
cy.get('[data-testid="SaveChangesPanel__save-btn"]').click();
// * Verify changes are saved
cy.get('.SaveChangesPanel').should('contain', 'Settings saved');
// * Verify URL is still the original URL after saving
cy.get('@originalUrl').then((originalUrl) => {
cy.get('.url-input-label').should('contain', originalUrl);
});
// # Verify URL only changes when explicitly modified
// # Click the URL edit button to enable URL editing
cy.get('.url-input-button').click();
// # Modify the URL explicitly
cy.get('.url-input-container input').clear().type('explicitly-changed-url');
// # Confirm the URL change
cy.get('.url-input-container button.url-input-button').click();
// * Verify URL has been updated to the new value
cy.get('.url-input-label').should('contain', 'explicitly-changed-url');
// # Save the URL change
cy.get('[data-testid="SaveChangesPanel__save-btn"]').click();
// * Verify changes are saved
cy.get('.SaveChangesPanel').should('contain', 'Settings saved');
// # Close the modal
cy.get('.GenericModal .modal-header button[aria-label="Close"]').click();
// * Verify the URL has actually changed by checking the browser URL
cy.url().should('include', 'explicitly-changed-url');
// # Verify subsequent name changes still don't affect the explicitly set URL
// # Open channel settings modal again
cy.get('#channelHeaderDropdownButton').click();
cy.findByText('Channel Settings').click();
// # Store the current URL (which should be the explicitly changed one)
cy.get('.url-input-label').invoke('val').as('currentUrl');
// # Change the channel name again
cy.get('#input_channel-settings-name').clear().type('Another Name Change');
// * Verify URL remains the explicitly set URL, not auto-generated from new name
cy.get('@currentUrl').then((currentUrl) => {
cy.get('.url-input-label').should('contain', currentUrl);
});
// * Verify URL does NOT contain auto-generated value from new name
cy.get('.url-input-label').should('not.contain', 'another-name-change');
// # Save the second name change
cy.get('[data-testid="SaveChangesPanel__save-btn"]').click();
// * Verify changes are saved
cy.get('.SaveChangesPanel').should('contain', 'Settings saved');
// * Final verification: URL should still be the explicitly set one
cy.get('@currentUrl').then((currentUrl) => {
cy.get('.url-input-label').should('contain', currentUrl);
});
});
});
it('MM-T4: Shows error for invalid channel name', () => {
// # Open channel settings modal
cy.get('#channelHeaderDropdownButton').click();

15
e2e-tests/cypress/tests/integration/channels/channel/channel_settings_spec.ts
Просмотреть файл

@@ -34,15 +34,22 @@ describe('Channel Settings', () => {
it('MM-T882 Channel URL validation works properly', () => {
cy.apiCreateChannel(testTeam.id, 'channel-test', 'Channel').then(({channel}) => {
// # Go to test channel
// # Go to test channel
cy.visit(`/${testTeam.name}/channels/${channel.name}`);
// # Go to channel dropdown > Channel Settings Modal
cy.get('#channelHeaderDropdownButton').click();
cy.findByText('Channel Settings').click();
// # Try to enter existing URL and save
// # Change channel name (this should NOT affect the URL anymore)
cy.get('#input_channel-settings-name').clear().type('town-square');
// # Now explicitly change the URL to trigger the validation error
cy.get('.url-input-button').click();
cy.get('.url-input-container input').clear().type('town-square');
cy.get('.url-input-container button.url-input-button').click();
// # Try to save
cy.get('[data-testid="SaveChangesPanel__save-btn"]').click();
// # Error is displayed and URL is unchanged
@@ -52,7 +59,9 @@ describe('Channel Settings', () => {
cy.url().should('include', `/${testTeam.name}/channels/${channel.name}`);
// # Enter a new URL and save
cy.get('#input_channel-settings-name').clear().type('another-town-square');
cy.get('.url-input-container input').clear().type('another-town-square');
cy.get('.url-input-button').click();
cy.get('.url-input-container button.url-input-button').click();
cy.get('[data-testid="SaveChangesPanel__save-btn"]').click();
// * URL is updated and no errors are displayed

5
e2e-tests/cypress/tests/integration/channels/channel_settings/channel_name_validations_spec.ts
Просмотреть файл

@@ -112,6 +112,11 @@ describe('Channel routing', () => {
// i.e. a total of 54 characters separated by 2 spaces
cy.get('#input_channel-settings-name').clear().type(`${firstWord}${Cypress._.repeat(' ', 2)}${secondWord}`);
// # Since channel name no longer auto-updates URL, manually set the URL to test the space handling
cy.get('.url-input-button').click();
cy.get('.url-input-container input').clear().type(`${firstWord}${Cypress._.repeat(' ', 2)}${secondWord}`);
cy.get('.url-input-container button.url-input-button').click();
// # Save changes
cy.get('[data-testid="SaveChangesPanel__save-btn"]').click();