From 12308f36120e69d21a1daa7d30335db6dd3525a5 Mon Sep 17 00:00:00 2001 From: Allan Guwatudde Date: Tue, 8 Mar 2022 19:14:20 +0300 Subject: [PATCH] [MM-42121] - Inactive Server Email Notification sends duplicate emails of every admin to original admin (#19668) Automatic Merge --- app/server_inactivity.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/server_inactivity.go b/app/server_inactivity.go index 363c5aab0e..177cf3e8e3 100644 --- a/app/server_inactivity.go +++ b/app/server_inactivity.go @@ -112,6 +112,10 @@ func (s *Server) takeInactivityAction() { } for _, user := range users { + + // See https://go.dev/doc/faq#closures_and_goroutines for why we make this assignment + user := user + if user.Email == "" { mlog.Error("Invalid system admin email.", mlog.String("user_email", user.Email)) continue