diff --git a/app/plugin_requests.go b/app/plugin_requests.go index 672237bccb..f7ba521e96 100644 --- a/app/plugin_requests.go +++ b/app/plugin_requests.go @@ -87,9 +87,14 @@ func (a *App) servePluginRequest(w http.ResponseWriter, r *http.Request, handler } // ToDo(DSchalla) 2019/01/04: Remove after deprecation period and only allow CSRF Header (MM-13657) - if !*a.Config().ServiceSettings.ExperimentalStrictCSRFEnforcement && r.Header.Get(model.HEADER_REQUESTED_WITH) == model.HEADER_REQUESTED_WITH_XML && !csrfCheckPassed { - a.Log.Warn("CSRF Check failed for request - Please migrate your plugin to either send a CSRF Header or Form Field, XMLHttpRequest is deprecated") - csrfCheckPassed = true + if r.Header.Get(model.HEADER_REQUESTED_WITH) == model.HEADER_REQUESTED_WITH_XML && !csrfCheckPassed { + csrfErrorMessage := "CSRF Check failed for request - Please migrate your plugin to either send a CSRF Header or Form Field, XMLHttpRequest is deprecated" + if *a.Config().ServiceSettings.ExperimentalStrictCSRFEnforcement { + a.Log.Warn(csrfErrorMessage) + } else { + a.Log.Debug(csrfErrorMessage) + csrfCheckPassed = true + } } } else { csrfCheckPassed = true diff --git a/web/handlers.go b/web/handlers.go index 9303119871..36e91bc86b 100644 --- a/web/handlers.go +++ b/web/handlers.go @@ -101,10 +101,15 @@ func (h Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) { csrfHeader := r.Header.Get(model.HEADER_CSRF_TOKEN) if csrfHeader == session.GetCSRF() { csrfCheckPassed = true - } else if !*c.App.Config().ServiceSettings.ExperimentalStrictCSRFEnforcement && r.Header.Get(model.HEADER_REQUESTED_WITH) == model.HEADER_REQUESTED_WITH_XML { + } else if r.Header.Get(model.HEADER_REQUESTED_WITH) == model.HEADER_REQUESTED_WITH_XML { // ToDo(DSchalla) 2019/01/04: Remove after deprecation period and only allow CSRF Header (MM-13657) - c.Log.Warn("CSRF Header check failed for request - Please upgrade your web application or custom app to set a CSRF Header") - csrfCheckPassed = true + csrfErrorMessage := "CSRF Header check failed for request - Please upgrade your web application or custom app to set a CSRF Header" + if *c.App.Config().ServiceSettings.ExperimentalStrictCSRFEnforcement { + c.Log.Warn(csrfErrorMessage) + } else { + c.Log.Debug(csrfErrorMessage) + csrfCheckPassed = true + } } if !csrfCheckPassed {