From 11debb55a67b55f27bd07d15a8204d126498ea7b Mon Sep 17 00:00:00 2001 From: Miguel de la Cruz Date: Wed, 25 Mar 2020 23:50:11 +0100 Subject: [PATCH] [MM-23510] Avoid race condition searching post's channel by channel id instead of post id (#14154) --- store/searchlayer/post_layer.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/store/searchlayer/post_layer.go b/store/searchlayer/post_layer.go index 4e53e5d40e..74723f4585 100644 --- a/store/searchlayer/post_layer.go +++ b/store/searchlayer/post_layer.go @@ -19,9 +19,9 @@ func (s SearchPostStore) indexPost(post *model.Post) { for _, engine := range s.rootStore.searchEngine.GetActiveEngines() { if engine.IsIndexingEnabled() { go (func(engineCopy searchengine.SearchEngineInterface) { - channel, chanErr := s.rootStore.Channel().GetForPost(post.Id) + channel, chanErr := s.rootStore.Channel().Get(post.ChannelId, true) if chanErr != nil { - mlog.Error("Couldn't get channel for post for SearchEngine indexing.", mlog.String("channel_id", post.ChannelId), mlog.String("search_engine", engineCopy.GetName()), mlog.String("post_id", post.Id)) + mlog.Error("Couldn't get channel for post for SearchEngine indexing.", mlog.String("channel_id", post.ChannelId), mlog.String("search_engine", engineCopy.GetName()), mlog.String("post_id", post.Id), mlog.Err(chanErr)) return } if err := engineCopy.IndexPost(post, channel.TeamId); err != nil {