MM - 19155 Change plugin helpers files to be golint complied (#12686)

* MM-19155 Change plugin helpers files to be golint complied

* add makefile target that checks if plugin/helpers files are golint
  compliant

* MM-19155 - Change plugin helpers files to be golint complied

* added comment documentation to exported plugin/helpers methods
* changed variable names to be compliant with golint

* Address feedback
Этот коммит содержится в:
Andres
2019-11-11 21:29:21 -08:00
коммит произвёл Ben Schumacher
родитель 36f3b14420
Коммит 1155b08404
3 изменённых файлов: 21 добавлений и 12 удалений

Просмотреть файл

@@ -230,7 +230,10 @@ check-prereqs: ## Checks prerequisite software status.
./scripts/prereq-check.sh
# TODO: remove govet and gofmt checks once golangci-lint is being enforced.
check-style: govet gofmt check-licenses ## Runs govet and gofmt against all packages.
check-style: govet gofmt check-licenses check-plugin-golint ## Runs govet and gofmt against all packages and also ensures plugin package golint compliant
check-plugin-golint: # Checks if golint returns any uncompliant code for any file that starts with plugin/helpers
@! golint ./plugin/ | grep plugin/helpers
test-te-race: ## Checks for race conditions in the team edition.
@echo Testing TE race conditions