From 0feb800bf00fa130bf020a5185e58212b001c482 Mon Sep 17 00:00:00 2001 From: Conor Macpherson Date: Thu, 20 Apr 2023 16:51:20 -0400 Subject: [PATCH] Add missing text for overage banner. --- .../overage_users_banner/index.tsx | 14 +++++++++- .../hooks/useExpandOverageUsersCheck.ts | 28 +++++++++++++------ 2 files changed, 33 insertions(+), 9 deletions(-) diff --git a/webapp/channels/src/components/announcement_bar/overage_users_banner/index.tsx b/webapp/channels/src/components/announcement_bar/overage_users_banner/index.tsx index 1aa37d047b..faee1da5ba 100644 --- a/webapp/channels/src/components/announcement_bar/overage_users_banner/index.tsx +++ b/webapp/channels/src/components/announcement_bar/overage_users_banner/index.tsx @@ -78,6 +78,7 @@ const OverageUsersBanner = () => { licenseId: license.Id, isWarningState: isBetween5PercerntAnd10PercentPurchasedSeats, banner: 'global banner', + canSelfHostedExpand: canSelfHostedExpand || false, }); const handleClose = () => { @@ -113,7 +114,7 @@ const OverageUsersBanner = () => { return null; } - const message = ( + let message = ( { seats: overageByUsers, }} />); + + if (canSelfHostedExpand) { + message = ( + ); + } return ( { const {formatMessage} = useIntl(); const dispatch = useDispatch(); const {getRequestState, is_expandable: isExpandable}: LicenseSelfServeStatusReducer = useSelector((state: GlobalState) => state.entities.cloud.subscriptionStats || {is_expandable: false, getRequestState: 'IDLE'}); const expandableLink = useSelector(getExpandSeatsLink); - const cta = useMemo(() => (isExpandable ? formatMessage({ - id: 'licensingPage.overageUsersBanner.ctaExpandSeats', - defaultMessage: 'Purchase additional seats', - }) : formatMessage({ - id: 'licensingPage.overageUsersBanner.cta', - defaultMessage: 'Contact Sales', - }) - ), [isExpandable]); + const cta = useMemo(() => { + if (isExpandable && !canSelfHostedExpand) { + return formatMessage({ + id: 'licensingPage.overageUsersBanner.ctaExpandSeats', + defaultMessage: 'Purchase additional seats', + }); + } else if (isExpandable && canSelfHostedExpand) { + return formatMessage({ + id: 'licensingPage.overageUsersBanner.ctaUpdateSeats', + defaultMessage: 'Update seat count', + }); + } else { + return formatMessage({ + id: 'licensingPage.overageUsersBanner.cta', + defaultMessage: 'Contact Sales', + }); + } + }, [isExpandable]); const trackEventFn = (cta: 'Contact Sales' | 'Self Serve') => { trackEvent('insights', isWarningState ? 'click_true_up_warning' : 'click_true_up_error', {