Replacing {require,assert}.{Nil,NotNil} with {require,assert}.{NoError,Error} in the store tests (when comparing errors) (#16886)

* Replacing require.Nil with require.NoError

* More replacements

* More Nil/NotNill to NoError/Error

* Other detected errors

* renaming apperr to err

* Removed not needed line

* Rename old appErr variables that are no longer model.AppError values

* Fixing tiny typo

* Reverting changes outside the store (accidentally added)

* Apply suggestions from code review

Co-authored-by: Doug Lauder <wiggin77@warpmail.net>

Co-authored-by: Doug Lauder <wiggin77@warpmail.net>

store/sqlstore/preference_store_test.go

@@ -53,7 +53,7 @@ func TestDeleteUnusedFeatures(t *testing.T) {
 		}
 
 		err := ss.Preference().Save(&features)
-		require.Nil(t, err)
+		require.NoError(t, err)
 
 		ss.Preference().(*SqlPreferenceStore).deleteUnusedFeatures()
 
@@ -63,7 +63,7 @@ func TestDeleteUnusedFeatures(t *testing.T) {
                     WHERE Category = :Category
                     AND Value = :Val
                     AND Name LIKE '`+store.FeatureTogglePrefix+`%'`, map[string]interface{}{"Category": model.PREFERENCE_CATEGORY_ADVANCED_SETTINGS, "Val": "false"}); err != nil {
-			require.Nil(t, err)
+			require.NoError(t, err)
 		} else if val != 0 {
 			require.Fail(t, "Found %d features with value 'false', expected all to be deleted", val)
 		}
@@ -74,7 +74,7 @@ func TestDeleteUnusedFeatures(t *testing.T) {
                     WHERE Category = :Category
                     AND Value = :Val
                     AND Name LIKE '`+store.FeatureTogglePrefix+`%'`, map[string]interface{}{"Category": model.PREFERENCE_CATEGORY_ADVANCED_SETTINGS, "Val": "true"}); err != nil {
-			require.Nil(t, err)
+			require.NoError(t, err)
 		} else if val == 0 {
 			require.Fail(t, "Found %d features with value 'true', expected to find at least %d features", val, 2)
 		}