Mm 23710 mmctl local mode (#14561)

* [MM-24146] Add unix socket listener for mmctl local mode (#14296)

* add unix socket listener for mmctl local mode

* add a constant for local-mode socket path

* reflect review comments

* [MM-24401] Base approach for Local Mode (#14333)

* add unix socket listener for mmctl local mode

* First working PoC

* Adds the channel list endpoint

* Add team list endpoint

* Add a LocalClient to the api test helper and start local mode

* Add helper to test with both SystemAdmin and Local clients

* Add some docs

* Adds TestForAllClients test helper

* Incorporating @ashishbhate's proposal for adding test names to the helpers

* Fix init errors after merge

* Adds create channel tests

* Always init local mode to allow for enabling-disabling it via config

* Check the RemoteAddr of the request before marking session as local

* Mark the request as errored if it's local and the origin is remote

* Set the socket permissions to read/write when initialising

* Fix linter

* Replace RemoteAddr check to ditch connections with the IP:PORT shape

Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>

* Fix translations order

* [MM-24832] Migrate plugin endpoints to local mode (#14543)

* [MM-24832] Migrate plugin endpoints to local mode

* Fix client reference in helper

* [MM-24776] Migrate config endpoints to local mode (#14544)

* [MM-24776] Migrate get config endpoint to local mode

* [MM-24777] Migrate update config endpoint to local mode

* Fix update config to bypass RestrictSystemAdmin flag

* Add patchConfig endpoint

* MM-24774/MM-24755: local mode for addLicense and removeLicense (#14491)

Automatic Merge

Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
Co-authored-by: Ashish Bhate <bhate.ashish@gmail.com>

api4/license_test.go

@@ -47,6 +47,7 @@ func TestUploadLicenseFile(t *testing.T) {
 	th := Setup(t).InitBasic()
 	defer th.TearDown()
 	Client := th.Client
+	LocalClient := th.LocalClient
 
 	t.Run("as system user", func(t *testing.T) {
 		ok, resp := Client.UploadLicenseFile([]byte{})
@@ -54,11 +55,11 @@ func TestUploadLicenseFile(t *testing.T) {
 		require.False(t, ok)
 	})
 
-	t.Run("as system admin user", func(t *testing.T) {
-		ok, resp := th.SystemAdminClient.UploadLicenseFile([]byte{})
+	th.TestForSystemAdminAndLocal(t, func(t *testing.T, c *model.Client4) {
+		ok, resp := c.UploadLicenseFile([]byte{})
 		CheckBadRequestStatus(t, resp)
 		require.False(t, ok)
-	})
+	}, "as system admin user")
 
 	t.Run("as restricted system admin user", func(t *testing.T) {
 		th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ExperimentalSettings.RestrictSystemAdmin = true })
@@ -67,12 +68,20 @@ func TestUploadLicenseFile(t *testing.T) {
 		CheckForbiddenStatus(t, resp)
 		require.False(t, ok)
 	})
+
+	t.Run("restricted admin setting not honoured through local client", func(t *testing.T) {
+		th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ExperimentalSettings.RestrictSystemAdmin = true })
+		ok, resp := LocalClient.UploadLicenseFile([]byte{})
+		CheckBadRequestStatus(t, resp)
+		require.False(t, ok)
+	})
 }
 
 func TestRemoveLicenseFile(t *testing.T) {
 	th := Setup(t).InitBasic()
 	defer th.TearDown()
 	Client := th.Client
+	LocalClient := th.LocalClient
 
 	t.Run("as system user", func(t *testing.T) {
 		ok, resp := Client.RemoveLicenseFile()
@@ -80,11 +89,11 @@ func TestRemoveLicenseFile(t *testing.T) {
 		require.False(t, ok)
 	})
 
-	t.Run("as system admin user", func(t *testing.T) {
-		ok, resp := th.SystemAdminClient.RemoveLicenseFile()
+	th.TestForSystemAdminAndLocal(t, func(t *testing.T, c *model.Client4) {
+		ok, resp := c.RemoveLicenseFile()
 		CheckNoError(t, resp)
 		require.True(t, ok)
-	})
+	}, "as system admin user")
 
 	t.Run("as restricted system admin user", func(t *testing.T) {
 		th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ExperimentalSettings.RestrictSystemAdmin = true })
@@ -93,4 +102,12 @@ func TestRemoveLicenseFile(t *testing.T) {
 		CheckForbiddenStatus(t, resp)
 		require.False(t, ok)
 	})
+
+	t.Run("restricted admin setting not honoured through local client", func(t *testing.T) {
+		th.App.UpdateConfig(func(cfg *model.Config) { *cfg.ExperimentalSettings.RestrictSystemAdmin = true })
+
+		ok, resp := LocalClient.RemoveLicenseFile()
+		CheckNoError(t, resp)
+		require.True(t, ok)
+	})
 }