#146 Terms of Service Phase 2 (#9731)

* #132 added UserTermsOfService model

* #132 added UserTermsOfService model

* #132 added logic to save user TOS data in a new table

* #132 Added logic to save and delete user TOS. Updated user TOS action logic

* #132 updated store mocks

* #132 added tests

* #132 removed cache from UserTermsOfService SQL store

* #132 fixed styling and license check

* #132 added message translations in en.json

* #132 fixed save user TOS logic to work second time as well

* #132 removed User.AcceptedTermsOfService colum and migrated accepted TOS data into new table

* #132 fixed formatting

* #132 fixed formatting

* #146 added field 'mandatory' to terms of service

* #146 updated tests

* #146 added getLatestTermsOfService API

* #146 Added tests

* #146 fixed styling

* #146 removed code for managing mandatory/optional TOS

* #146 Added TOS re-acceptance period config

* #146 fixed styling

* #146 removed some code left for debugging

* #146 added TOS re-acceptance period in config

* #146 fixed a json name from service_terms to terms_of_service

* #146 Minor refactoring and added TOS re-acceptance period to diagnistics

* Fixed style

* Updated upgraded script to keep app backward compatible

app/user_test.go

@@ -544,43 +544,3 @@ func TestPermanentDeleteUser(t *testing.T) {
 		t.Fatal("GetFileInfo after DeleteUser is nil")
 	}
 }
-
-func TestRecordUserTermsOfServiceAction(t *testing.T) {
-	th := Setup().InitBasic()
-	defer th.TearDown()
-
-	user := &model.User{
-		Email:       strings.ToLower(model.NewId()) + "success+test@example.com",
-		Nickname:    "Luke Skywalker", // trying to bring balance to the "Force", one test user at a time
-		Username:    "luke" + model.NewId(),
-		Password:    "passwd1",
-		AuthService: "",
-	}
-	user, err := th.App.CreateUser(user)
-	if err != nil {
-		t.Fatalf("failed to create user: %v", err)
-	}
-
-	defer th.App.PermanentDeleteUser(user)
-
-	termsOfService, err := th.App.CreateTermsOfService("text", user.Id)
-	if err != nil {
-		t.Fatalf("failed to create terms of service: %v", err)
-	}
-
-	err = th.App.RecordUserTermsOfServiceAction(user.Id, termsOfService.Id, true)
-	if err != nil {
-		t.Fatalf("failed to record user action: %v", err)
-	}
-
-	nuser, err := th.App.GetUser(user.Id)
-	assert.Equal(t, termsOfService.Id, nuser.AcceptedTermsOfServiceId)
-
-	err = th.App.RecordUserTermsOfServiceAction(user.Id, termsOfService.Id, false)
-	if err != nil {
-		t.Fatalf("failed to record user action: %v", err)
-	}
-
-	nuser, err = th.App.GetUser(user.Id)
-	assert.Empty(t, nuser.AcceptedTermsOfServiceId)
-}