From 0a92eb6363c4057ed3516b44d3dab660fe4c4f4f Mon Sep 17 00:00:00 2001 From: Arya Khochare <91268931+Aryakoste@users.noreply.github.com> Date: Fri, 4 Oct 2024 21:21:38 +0530 Subject: [PATCH] errcheck issues fixed (#28418) --- server/.golangci.yml | 1 - server/channels/api4/ldap.go | 8 ++++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index bc13bc06d7..88a5c61fc9 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -87,7 +87,6 @@ issues: channels/api4/ip_filtering.go|\ channels/api4/ip_filtering_test.go|\ channels/api4/job_test.go|\ - channels/api4/ldap.go|\ channels/api4/license.go|\ channels/api4/license_local.go|\ channels/api4/license_test.go|\ diff --git a/server/channels/api4/ldap.go b/server/channels/api4/ldap.go index 0669332328..8d2d03b860 100644 --- a/server/channels/api4/ldap.go +++ b/server/channels/api4/ldap.go @@ -140,7 +140,9 @@ func getLdapGroups(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(b) + if _, err := w.Write(b); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func linkLdapGroup(c *Context, w http.ResponseWriter, r *http.Request) { @@ -240,7 +242,9 @@ func linkLdapGroup(c *Context, w http.ResponseWriter, r *http.Request) { auditRec.Success() w.WriteHeader(status) - w.Write(b) + if _, err := w.Write(b); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func unlinkLdapGroup(c *Context, w http.ResponseWriter, r *http.Request) {