diff --git a/server/public/model/config.go b/server/public/model/config.go index b6cdc74bf7..8f6500f99a 100644 --- a/server/public/model/config.go +++ b/server/public/model/config.go @@ -4848,6 +4848,10 @@ func (o *Config) Sanitize(pluginManifests []*Manifest, opts *SanitizeOptions) { *o.FileSettings.AmazonS3SecretAccessKey = FakeSetting } + if o.FileSettings.ExportAmazonS3SecretAccessKey != nil && *o.FileSettings.ExportAmazonS3SecretAccessKey != "" { + *o.FileSettings.ExportAmazonS3SecretAccessKey = FakeSetting + } + if o.EmailSettings.SMTPPassword != nil && *o.EmailSettings.SMTPPassword != "" { *o.EmailSettings.SMTPPassword = FakeSetting } @@ -4880,6 +4884,10 @@ func (o *Config) Sanitize(pluginManifests []*Manifest, opts *SanitizeOptions) { *o.ElasticsearchSettings.Password = FakeSetting } + if o.ElasticsearchSettings.ClientKey != nil && *o.ElasticsearchSettings.ClientKey != "" { + *o.ElasticsearchSettings.ClientKey = FakeSetting + } + for i := range o.SqlSettings.DataSourceReplicas { o.SqlSettings.DataSourceReplicas[i] = sanitizeDataSourceField(o.SqlSettings.DataSourceReplicas[i], "SqlSettings.DataSourceReplicas") } @@ -4905,6 +4913,14 @@ func (o *Config) Sanitize(pluginManifests []*Manifest, opts *SanitizeOptions) { *o.ServiceSettings.SplitKey = FakeSetting } + if o.ServiceSettings.GoogleDeveloperKey != nil && *o.ServiceSettings.GoogleDeveloperKey != "" { + *o.ServiceSettings.GoogleDeveloperKey = FakeSetting + } + + if o.ServiceSettings.GiphySdkKey != nil && *o.ServiceSettings.GiphySdkKey != "" { + *o.ServiceSettings.GiphySdkKey = FakeSetting + } + if o.CacheSettings.RedisPassword != nil { *o.CacheSettings.RedisPassword = FakeSetting } diff --git a/server/public/model/config_test.go b/server/public/model/config_test.go index d703b4b63a..32c5279cf5 100644 --- a/server/public/model/config_test.go +++ b/server/public/model/config_test.go @@ -1513,9 +1513,13 @@ func TestConfigSanitize(t *testing.T) { *c.LdapSettings.BindPassword = "foo" *c.FileSettings.AmazonS3SecretAccessKey = "bar" + *c.FileSettings.ExportAmazonS3SecretAccessKey = "export-secret" *c.EmailSettings.SMTPPassword = "baz" *c.GitLabSettings.Secret = "bingo" *c.OpenIdSettings.Secret = "secret" + *c.ServiceSettings.GoogleDeveloperKey = "google-api-key" + *c.ServiceSettings.GiphySdkKey = "giphy-sdk-key" + *c.ElasticsearchSettings.ClientKey = "/path/to/client-key.pem" c.SqlSettings.DataSourceReplicas = []string{"stuff"} c.SqlSettings.DataSourceSearchReplicas = []string{"stuff"} c.SqlSettings.ReplicaLagSettings = []*ReplicaLagSettings{{ @@ -1529,12 +1533,16 @@ func TestConfigSanitize(t *testing.T) { assert.Equal(t, FakeSetting, *c.LdapSettings.BindPassword) assert.Equal(t, FakeSetting, *c.FileSettings.PublicLinkSalt) assert.Equal(t, FakeSetting, *c.FileSettings.AmazonS3SecretAccessKey) + assert.Equal(t, FakeSetting, *c.FileSettings.ExportAmazonS3SecretAccessKey) assert.Equal(t, FakeSetting, *c.EmailSettings.SMTPPassword) assert.Equal(t, FakeSetting, *c.GitLabSettings.Secret) assert.Equal(t, FakeSetting, *c.OpenIdSettings.Secret) assert.Equal(t, FakeSetting, *c.SqlSettings.DataSource) assert.Equal(t, FakeSetting, *c.SqlSettings.AtRestEncryptKey) assert.Equal(t, FakeSetting, *c.ElasticsearchSettings.Password) + assert.Equal(t, FakeSetting, *c.ElasticsearchSettings.ClientKey) + assert.Equal(t, FakeSetting, *c.ServiceSettings.GoogleDeveloperKey) + assert.Equal(t, FakeSetting, *c.ServiceSettings.GiphySdkKey) assert.Equal(t, FakeSetting, c.SqlSettings.DataSourceReplicas[0]) assert.Equal(t, FakeSetting, c.SqlSettings.DataSourceSearchReplicas[0])