From 0635306f6e5d11a6390483ebf003d2d792239705 Mon Sep 17 00:00:00 2001 From: Harrison Healey Date: Wed, 18 Dec 2024 14:22:47 -0500 Subject: [PATCH] MM-62060/MM-62276 Remove video from onboarding checklist and turn iframe-has-title ESLint rule to error (#29634) * MM-62276 Remove video from onboarding checklist * MM-62060 Turn jsx-a11y/iframe-has-title ESLint rule to an error --- .../onboarding_tasklist.tsx | 64 +------------------ .../components/onboarding_tasks/constants.ts | 1 - .../onboarding_video_modal.scss | 61 ------------------ .../onboarding_video_modal.tsx | 64 ------------------- webapp/channels/src/i18n/en.json | 1 - .../src/images/onboarding-checklist.svg | 10 --- .../configs/.eslintrc-react.json | 2 +- 7 files changed, 2 insertions(+), 201 deletions(-) delete mode 100644 webapp/channels/src/components/onboarding_tasks/onboarding_video_modal/onboarding_video_modal.scss delete mode 100644 webapp/channels/src/components/onboarding_tasks/onboarding_video_modal/onboarding_video_modal.tsx delete mode 100644 webapp/channels/src/images/onboarding-checklist.svg diff --git a/webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx b/webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx index 896ace0cb6..7a82866a5c 100644 --- a/webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx +++ b/webapp/channels/src/components/onboarding_tasklist/onboarding_tasklist.tsx @@ -6,7 +6,7 @@ import {FormattedMessage} from 'react-intl'; import {useDispatch, useSelector} from 'react-redux'; import styled, {css} from 'styled-components'; -import {CloseIcon, PlayIcon, PlaylistCheckIcon} from '@mattermost/compass-icons/components'; +import {CloseIcon, PlaylistCheckIcon} from '@mattermost/compass-icons/components'; import {getPrevTrialLicense} from 'mattermost-redux/actions/admin'; import {getMyPreferences, savePreferences} from 'mattermost-redux/actions/preferences'; @@ -19,7 +19,6 @@ import { import {getCurrentUserId} from 'mattermost-redux/selectors/entities/users'; import {trackEvent} from 'actions/telemetry_actions'; -import {openModal} from 'actions/views/modals'; import {getShowTaskListBool} from 'selectors/onboarding'; import CompassThemeProvider from 'components/compass_theme_provider/compass_theme_provider'; @@ -30,9 +29,7 @@ import { OnboardingTaskList, } from 'components/onboarding_tasks'; import {useHandleOnBoardingTaskTrigger} from 'components/onboarding_tasks/onboarding_tasks_manager'; -import OnBoardingVideoModal from 'components/onboarding_tasks/onboarding_video_modal/onboarding_video_modal'; -import checklistImg from 'images/onboarding-checklist.svg'; import {Preferences, RecommendedNextStepsLegacy} from 'utils/constants'; import type {GlobalState} from 'types/store'; @@ -126,40 +123,6 @@ const Button = styled.button<{open: boolean}>(({open}) => { `; }); -const PlayButton = styled.button` - padding: 10px 0; - max-width: 175px; - background: var(--button-bg); - border-radius: var(--radius-s); - color: var(--button-color); - border: none; - font-weight: bold; - position: absolute; - z-index: 1; - margin-left: auto; - margin-right: auto; - left: 0; - right: 0; - top: 48px; - - &:hover { - border-color: rgba(var(--center-channel-color-rgb), 0.24); - box-shadow: var(--elevation-4); - } - - svg { - margin-right: 6px; - vertical-align: middle; - } -`; - -const Skeleton = styled.div` - height: auto; - margin: 0 auto; - padding: 0 20px; - position: relative; -`; - const OnBoardingTaskList = (): JSX.Element | null => { const hasPreferences = useSelector((state: GlobalState) => Object.keys(getMyPreferencesSelector(state)).length !== 0); @@ -278,15 +241,6 @@ const OnBoardingTaskList = (): JSX.Element | null => { trackEvent(OnboardingTaskCategory, open ? OnboardingTaskList.ONBOARDING_TASK_LIST_CLOSE : OnboardingTaskList.ONBOARDING_TASK_LIST_OPEN); }, [open, currentUserId]); - const openVideoModal = useCallback(() => { - toggleTaskList(); - dispatch(openModal({ - modalId: OnboardingTaskList.ONBOARDING_VIDEO_MODAL, - dialogType: OnBoardingVideoModal, - dialogProps: {}, - })); - }, []); - if (!hasPreferences || !showTaskList || !isEnableOnboardingFlow) { return null; } @@ -329,22 +283,6 @@ const OnBoardingTaskList = (): JSX.Element | null => { defaultMessage="Let's get up and running." />

- - {'On - - - - - {tasksList.map((task) => ( void; -} - -const OnBoardingVideoModal = ({onExited}: Props) => { - const [show, setShow] = useState(true); - const dispatch = useDispatch(); - const currentUserId = useSelector(getCurrentUserId); - - const handleHide = useCallback(() => { - setShow(false); - const preferences = [{ - user_id: currentUserId, - category: OnboardingTaskCategory, - name: OnboardingTaskList.ONBOARDING_TASK_LIST_OPEN, - value: 'true', - }]; - dispatch(savePreferences(currentUserId, preferences)); - }, [currentUserId]); - - return ( - - - -