From 058f235050428c9afb1fd70ebab872cd852c89ea Mon Sep 17 00:00:00 2001 From: upwell Date: Wed, 4 Mar 2020 00:42:17 +0800 Subject: [PATCH] [GH-13931] Return error in parseDSN func #13931 (#13947) Automatic Merge --- config/database.go | 2 +- config/database_test.go | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/config/database.go b/config/database.go index d5f4764be1..e07fd7fe37 100644 --- a/config/database.go +++ b/config/database.go @@ -139,7 +139,7 @@ func parseDSN(dsn string) (string, string, error) { // Treat the DSN as the URL that it is. s := strings.SplitN(dsn, "://", 2) if len(s) != 2 { - errors.New("failed to parse DSN as URL") + return "", "", errors.New("failed to parse DSN as URL") } scheme := s[0] diff --git a/config/database_test.go b/config/database_test.go index 3ff1dddc32..3c61c6f8c1 100644 --- a/config/database_test.go +++ b/config/database_test.go @@ -155,6 +155,9 @@ func TestDatabaseStoreNew(t *testing.T) { t.Run("invalid url", func(t *testing.T) { _, err := config.NewDatabaseStore("") require.Error(t, err) + + _, err = config.NewDatabaseStore("mysql") + require.Error(t, err) }) t.Run("unsupported scheme", func(t *testing.T) {