Refactored post handling/updating on both the client and server.

api/channel.go

@@ -391,6 +391,8 @@ func JoinChannel(c *Context, channelId string, role string) {
 				c.Err = model.NewAppError("joinChannel", "Failed to send join request", "")
 				return
 			}
+
+			UpdateChannelAccessCacheAndForget(c.Session.TeamId, c.Session.UserId, channel.Id)
 		} else {
 			c.Err = model.NewAppError("joinChannel", "You do not have the appropriate permissions", "")
 			c.Err.StatusCode = http.StatusForbidden

api/post.go

@@ -28,6 +28,7 @@ func InitPost(r *mux.Router) {
 	sr.Handle("/valet_create", ApiUserRequired(createValetPost)).Methods("POST")
 	sr.Handle("/update", ApiUserRequired(updatePost)).Methods("POST")
 	sr.Handle("/posts/{offset:[0-9]+}/{limit:[0-9]+}", ApiUserRequiredActivity(getPosts, false)).Methods("GET")
+	sr.Handle("/posts/{time:[0-9]+}", ApiUserRequiredActivity(getPostsSince, false)).Methods("GET")
 	sr.Handle("/post/{post_id:[A-Za-z0-9]+}", ApiUserRequired(getPost)).Methods("GET")
 	sr.Handle("/post/{post_id:[A-Za-z0-9]+}/delete", ApiUserRequired(deletePost)).Methods("POST")
 }
@@ -545,9 +546,7 @@ func updatePost(c *Context, w http.ResponseWriter, r *http.Request) {
 		rpost := result.Data.(*model.Post)
 
 		message := model.NewMessage(c.Session.TeamId, rpost.ChannelId, c.Session.UserId, model.ACTION_POST_EDITED)
-		message.Add("post_id", rpost.Id)
-		message.Add("channel_id", rpost.ChannelId)
-		message.Add("message", rpost.Message)
+		message.Add("post", rpost.ToJson())
 
 		PublishAndForget(message)
 
@@ -603,6 +602,39 @@ func getPosts(c *Context, w http.ResponseWriter, r *http.Request) {
 
 }
 
+func getPostsSince(c *Context, w http.ResponseWriter, r *http.Request) {
+	params := mux.Vars(r)
+
+	id := params["id"]
+	if len(id) != 26 {
+		c.SetInvalidParam("getPostsSince", "channelId")
+		return
+	}
+
+	time, err := strconv.ParseInt(params["time"], 10, 64)
+	if err != nil {
+		c.SetInvalidParam("getPostsSince", "time")
+		return
+	}
+
+	cchan := Srv.Store.Channel().CheckPermissionsTo(c.Session.TeamId, id, c.Session.UserId)
+	pchan := Srv.Store.Post().GetPostsSince(id, time)
+
+	if !c.HasPermissionsToChannel(cchan, "getPostsSince") {
+		return
+	}
+
+	if result := <-pchan; result.Err != nil {
+		c.Err = result.Err
+		return
+	} else {
+		list := result.Data.(*model.PostList)
+
+		w.Write([]byte(list.ToJson()))
+	}
+
+}
+
 func getPost(c *Context, w http.ResponseWriter, r *http.Request) {
 	params := mux.Vars(r)
 

api/post_test.go

@@ -351,6 +351,76 @@ func TestGetPosts(t *testing.T) {
 	}
 }
 
+func TestGetPostsSince(t *testing.T) {
+	Setup()
+
+	team := &model.Team{DisplayName: "Name", Name: "z-z-" + model.NewId() + "a", Email: "test@nowhere.com", Type: model.TEAM_OPEN}
+	team = Client.Must(Client.CreateTeam(team)).Data.(*model.Team)
+
+	user1 := &model.User{TeamId: team.Id, Email: model.NewId() + "corey@test.com", Nickname: "Corey Hulen", Password: "pwd"}
+	user1 = Client.Must(Client.CreateUser(user1, "")).Data.(*model.User)
+	store.Must(Srv.Store.User().VerifyEmail(user1.Id))
+
+	Client.LoginByEmail(team.Name, user1.Email, "pwd")
+
+	channel1 := &model.Channel{DisplayName: "TestGetPosts", Name: "a" + model.NewId() + "a", Type: model.CHANNEL_OPEN, TeamId: team.Id}
+	channel1 = Client.Must(Client.CreateChannel(channel1)).Data.(*model.Channel)
+
+	time.Sleep(10 * time.Millisecond)
+	post0 := &model.Post{ChannelId: channel1.Id, Message: "a" + model.NewId() + "a"}
+	post0 = Client.Must(Client.CreatePost(post0)).Data.(*model.Post)
+
+	time.Sleep(10 * time.Millisecond)
+	post1 := &model.Post{ChannelId: channel1.Id, Message: "a" + model.NewId() + "a"}
+	post1 = Client.Must(Client.CreatePost(post1)).Data.(*model.Post)
+
+	time.Sleep(10 * time.Millisecond)
+	post1a1 := &model.Post{ChannelId: channel1.Id, Message: "a" + model.NewId() + "a", RootId: post1.Id}
+	post1a1 = Client.Must(Client.CreatePost(post1a1)).Data.(*model.Post)
+
+	time.Sleep(10 * time.Millisecond)
+	post2 := &model.Post{ChannelId: channel1.Id, Message: "a" + model.NewId() + "a"}
+	post2 = Client.Must(Client.CreatePost(post2)).Data.(*model.Post)
+
+	time.Sleep(10 * time.Millisecond)
+	post3 := &model.Post{ChannelId: channel1.Id, Message: "a" + model.NewId() + "a"}
+	post3 = Client.Must(Client.CreatePost(post3)).Data.(*model.Post)
+
+	time.Sleep(10 * time.Millisecond)
+	post3a1 := &model.Post{ChannelId: channel1.Id, Message: "a" + model.NewId() + "a", RootId: post3.Id}
+	post3a1 = Client.Must(Client.CreatePost(post3a1)).Data.(*model.Post)
+
+	r1 := Client.Must(Client.GetPostsSince(channel1.Id, post1.CreateAt)).Data.(*model.PostList)
+
+	if r1.Order[0] != post3a1.Id {
+		t.Fatal("wrong order")
+	}
+
+	if r1.Order[1] != post3.Id {
+		t.Fatal("wrong order")
+	}
+
+	if len(r1.Posts) != 5 {
+		t.Fatal("wrong size")
+	}
+
+	now := model.GetMillis()
+	r2 := Client.Must(Client.GetPostsSince(channel1.Id, now)).Data.(*model.PostList)
+
+	if len(r2.Posts) != 0 {
+		t.Fatal("should have been empty")
+	}
+
+	post2.Message = "new message"
+	Client.Must(Client.UpdatePost(post2))
+
+	r3 := Client.Must(Client.GetPostsSince(channel1.Id, now)).Data.(*model.PostList)
+
+	if len(r3.Order) != 2 { // 2 because deleted post is returned as well
+		t.Fatal("missing post update")
+	}
+}
+
 func TestSearchPosts(t *testing.T) {
 	Setup()
 

api/web_conn.go

@@ -121,6 +121,11 @@ func (c *WebConn) writePump() {
 	}
 }
 
+func (c *WebConn) updateChannelAccessCache(channelId string) {
+	allowed := hasPermissionsToChannel(Srv.Store.Channel().CheckPermissionsTo(c.TeamId, channelId, c.UserId))
+	c.ChannelAccessCache[channelId] = allowed
+}
+
 func hasPermissionsToChannel(sc store.StoreChannel) bool {
 	if cresult := <-sc; cresult.Err != nil {
 		return false

api/web_hub.go

@@ -30,6 +30,14 @@ func PublishAndForget(message *model.Message) {
 	}()
 }
 
+func UpdateChannelAccessCacheAndForget(teamId, userId, channelId string) {
+	go func() {
+		if nh, ok := hub.teamHubs[teamId]; ok {
+			nh.UpdateChannelAccessCache(userId, channelId)
+		}
+	}()
+}
+
 func (h *Hub) Register(webConn *WebConn) {
 	h.register <- webConn
 }

api/web_team_hub.go

@@ -77,3 +77,12 @@ func (h *TeamHub) Start() {
 		}
 	}()
 }
+
+func (h *TeamHub) UpdateChannelAccessCache(userId string, channelId string) {
+	for webCon := range h.connections {
+		if webCon.UserId == userId {
+			webCon.updateChannelAccessCache(channelId)
+			break
+		}
+	}
+}