Chore(cypress): Review and Fix tests failing on master (#26954)

e2e-tests/cypress/tests/integration/channels/enterprise/guest_accounts/guest_experience_ui_spec.ts

@@ -87,7 +87,7 @@ describe('Guest Account - Guest User Experience', () => {
 
         // * Verify Guest Badge in Channel Header
         cy.get('#channelHeaderDescription').within(($el) => {
-            cy.wrap($el).find('.has-guest-header').should('be.visible').and('have.text', 'This channel has guests');
+            cy.wrap($el).find('.has-guest-header').should('be.visible').and('have.text', 'Channel has guests');
         });
 
         // * Verify list of Users in Direct Messages Dialog

e2e-tests/cypress/tests/integration/channels/enterprise/guest_accounts/guest_identification_ui_not_cloud_spec.ts

@@ -48,10 +48,10 @@ describe('Verify Guest User Identification in different screens', () => {
         });
     });
 
-    it('MM-T1419 Deactivating a Guest removes "This channel has guests" message from channel header', () => {
-        // * Verify the text 'This channel has guests' is displayed in the header
+    it('MM-T1419 Deactivating a Guest removes "Channel has guests" message from channel header', () => {
+        // * Verify the text 'Channel has guests' is displayed in the header
         cy.get('#channelHeaderDescription').within(($el) => {
-            cy.wrap($el).find('.has-guest-header').should('be.visible').and('have.text', 'This channel has guests');
+            cy.wrap($el).find('.has-guest-header').should('be.visible').and('have.text', 'Channel has guests');
         });
 
         // # Deactivate Guest user
@@ -61,7 +61,7 @@ describe('Verify Guest User Identification in different screens', () => {
         cy.get('.SidebarChannel:contains(Town Square)').click();
         cy.get(`.SidebarChannel:contains(${testChannel.display_name})`).click();
 
-        // * Verify the text 'This channel has guests' is removed from the header
+        // * Verify the text 'Channel has guests' is removed from the header
         cy.get('#channelHeaderDescription').within(($el) => {
             cy.wrap($el).find('.has-guest-header').should('not.exist');
         });

e2e-tests/cypress/tests/integration/channels/enterprise/guest_accounts/guest_identification_ui_spec.ts

@@ -173,7 +173,7 @@ describe('Verify Guest User Identification in different screens', () => {
         // * Verify Guest Badge in DM header
         cy.get('#channelHeaderTitle').should('be.visible').find('.Tag').should('be.visible').and('have.text', 'GUEST');
         cy.get('#channelHeaderDescription').within(($el) => {
-            cy.wrap($el).find('.has-guest-header').should('be.visible').and('have.text', 'This channel has guests');
+            cy.wrap($el).find('.has-guest-header').should('be.visible').and('have.text', 'Channel has guests');
         });
 
         // # Open a GM with Guest User and Sysadmin

e2e-tests/cypress/tests/integration/channels/enterprise/system_console/support_packet_generation_spec.js

@@ -27,7 +27,7 @@ describe('Support Packet Generation', () => {
 
         goToSupportPacketGenerationModal();
 
-        cy.get('.AlertBanner__body').should('have.text', 'Before downloading the support packet, set Output Logs to File to true and set File Log Level to DEBUG here.');
+        cy.get('div.AlertBanner__body span').should('have.text', 'Before downloading the Support Packet, set Output Logs to File to true and set File Log Level to DEBUG here.');
     });
 
     it('MM-T3818 - Commercial Support Dialog UI - Links', () => {
@@ -37,7 +37,7 @@ describe('Support Packet Generation', () => {
         goToSupportPacketGenerationModal();
 
         // * Verify that the "submit a support ticket." link exist and points to Customer Support Request page
-        cy.findByRole('link', {name: 'submit a support ticket.'}).should('have.attr', 'href').and('include', 'https://support.mattermost.com/hc/en-us/requests/new');
+        cy.findByText('submit a support ticket').should('have.attr', 'href').and('include', 'https://support.mattermost.com/hc/en-us/requests/new');
 
         // * Verify that the "here" link exist and points to Logging admin page
         cy.findByRole('link', {name: 'here'}).should('have.attr', 'href').and('include', '/admin_console/environment/logging');
@@ -50,5 +50,5 @@ const goToSupportPacketGenerationModal = () => {
     cy.findByRole('button', {name: 'Commercial Support dialog'}).click();
 
     // * Ensure the download support packet button exist and that text regarding setting the proper settings exist
-    cy.findByRole('link', {name: 'Download Support Packet'}).should('exist');
+    cy.get('a.DownloadSupportPacket').should('exist');
 };