[MM-49751] - Turn off Inactive Server Email (#22648)

* [MM-49751] - Turn off Inactive Server Email

* remove unused var

---------

Co-authored-by: Mattermost Build <build@mattermost.com>

server/channels/app/email/email.go

@@ -11,8 +11,6 @@ import (
 	"io"
 	"net/http"
 	"net/url"
-	"os"
-	"strconv"
 	"strings"
 
 	"github.com/pkg/errors"
@@ -26,8 +24,6 @@ import (
 	"github.com/microcosm-cc/bluemonday"
 )
 
-const serverInactivityHours = 100
-
 // Returns category if enabled is true (default false)
 // If "" is returned when enabled is false, the category headers aren't attached to the email
 func getSendGridCategory(category string, enabled bool) string {
@@ -948,48 +944,6 @@ func (es *Service) CreateVerifyEmailToken(userID string, newEmail string) (*mode
 	return token, nil
 }
 
-func (es *Service) SendLicenseInactivityEmail(email, name, locale, siteURL string) error {
-	T := i18n.GetUserTranslations(locale)
-	subject := T("api.templates.server_inactivity_subject")
-	data := es.NewEmailTemplateData(locale)
-	data.Props["SiteURL"] = siteURL
-	data.Props["Title"] = T("api.templates.server_inactivity_title")
-	data.Props["SubTitle"] = T("api.templates.server_inactivity_subtitle", map[string]any{"Name": name})
-	data.Props["InfoBullet"] = T("api.templates.server_inactivity_info_bullet")
-	data.Props["InfoBullet1"] = T("api.templates.server_inactivity_info_bullet1")
-	data.Props["InfoBullet2"] = T("api.templates.server_inactivity_info_bullet2")
-	data.Props["Info"] = T("api.templates.server_inactivity_info")
-	data.Props["EmailUs"] = T("api.templates.email_us_anytime_at")
-	data.Props["QuestionTitle"] = T("api.templates.questions_footer.title")
-	data.Props["QuestionInfo"] = T("api.templates.questions_footer.info")
-	data.Props["Button"] = T("api.templates.server_inactivity_button")
-	data.Props["SupportEmail"] = "feedback@mattermost.com"
-	data.Props["ButtonURL"] = siteURL
-	data.Props["Channels"] = T("Channels")
-	data.Props["Playbooks"] = T("Playbooks")
-	data.Props["Boards"] = T("Boards")
-
-	inactivityDurationHoursEnv := os.Getenv("MM_INACTIVITY_DURATION")
-	inactivityDurationHours, parseError := strconv.ParseFloat(inactivityDurationHoursEnv, 64)
-	if parseError != nil {
-		// default to 100 hours
-		inactivityDurationHours = serverInactivityHours
-	}
-
-	data.Props["FooterDisclaimer"] = T("api.templates.server_inactivity_footer_disclaimer", map[string]any{"Hours": inactivityDurationHours})
-
-	body, err := es.templatesContainer.RenderToString("inactivity_body", data)
-	if err != nil {
-		return err
-	}
-
-	if err := es.sendMail(email, subject, body, "LicenseInactivityEmail"); err != nil {
-		return err
-	}
-
-	return nil
-}
-
 func (es *Service) SendLicenseUpForRenewalEmail(email, name, locale, siteURL, ctaTitle, ctaLink, ctaText string, daysToExpiration int) error {
 	T := i18n.GetUserTranslations(locale)
 	subject := T("api.templates.license_up_for_renewal_subject")

server/channels/app/email/email_test.go

@@ -408,7 +408,6 @@ func TestMailServiceConfig(t *testing.T) {
 					LoginButtonColor:                  new(string),
 					LoginButtonBorderColor:            new(string),
 					LoginButtonTextColor:              new(string),
-					EnableInactivityEmail:             new(bool),
 				},
 			}
 		},

server/channels/app/email/mocks/ServiceInterface.go

@@ -344,20 +344,6 @@ func (_m *ServiceInterface) SendInviteEmailsToTeamAndChannels(team *model.Team,
 	return r0, r1
 }
 
-// SendLicenseInactivityEmail provides a mock function with given fields: _a0, name, locale, siteURL
-func (_m *ServiceInterface) SendLicenseInactivityEmail(_a0 string, name string, locale string, siteURL string) error {
-	ret := _m.Called(_a0, name, locale, siteURL)
-
-	var r0 error
-	if rf, ok := ret.Get(0).(func(string, string, string, string) error); ok {
-		r0 = rf(_a0, name, locale, siteURL)
-	} else {
-		r0 = ret.Error(0)
-	}
-
-	return r0
-}
-
 // SendLicenseUpForRenewalEmail provides a mock function with given fields: _a0, name, locale, siteURL, ctaTitle, ctaLink, ctaText, daysToExpiration
 func (_m *ServiceInterface) SendLicenseUpForRenewalEmail(_a0 string, name string, locale string, siteURL string, ctaTitle string, ctaLink string, ctaText string, daysToExpiration int) error {
 	ret := _m.Called(_a0, name, locale, siteURL, ctaTitle, ctaLink, ctaText, daysToExpiration)

server/channels/app/email/service.go

@@ -163,7 +163,6 @@ type ServiceInterface interface {
 	InitEmailBatching()
 	SendChangeUsernameEmail(newUsername, email, locale, siteURL string) error
 	CreateVerifyEmailToken(userID string, newEmail string) (*model.Token, error)
-	SendLicenseInactivityEmail(email, name, locale, siteURL string) error
 	Stop()
 }
 

server/channels/app/server.go

@@ -484,7 +484,6 @@ func NewServer(options ...Option) (*Server, error) {
 		s.Go(func() {
 			appInstance := New(ServerConnector(s.Channels()))
 			s.runLicenseExpirationCheckJob()
-			s.runInactivityCheckJob()
 			runDNDStatusExpireJob(appInstance)
 			runPostReminderJob(appInstance)
 		})
@@ -1198,12 +1197,6 @@ func runConfigCleanupJob(s *Server) {
 	}, time.Hour*24)
 }
 
-func (s *Server) runInactivityCheckJob() {
-	model.CreateRecurringTask("Server inactivity Check", func() {
-		s.doInactivityCheck()
-	}, time.Hour*24)
-}
-
 func (s *Server) runLicenseExpirationCheckJob() {
 	s.doLicenseExpirationCheck()
 	model.CreateRecurringTask("License Expiration Check", func() {

server/channels/app/server_inactivity.go

@@ -1,119 +0,0 @@
-// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
-// See LICENSE.txt for license information.
-
-package app
-
-import (
-	"os"
-	"strconv"
-	"time"
-
-	"github.com/mattermost/mattermost-server/v6/model"
-	"github.com/mattermost/mattermost-server/v6/server/platform/shared/mlog"
-)
-
-const serverInactivityHours = 100
-const inactivityEmailSent = "INACTIVITY"
-
-func (s *Server) doInactivityCheck() {
-
-	if *s.platform.Config().ServiceSettings.EnableDeveloper {
-		mlog.Info("No activity check because developer mode is enabled")
-		return
-	}
-
-	if !*s.platform.Config().EmailSettings.EnableInactivityEmail {
-		mlog.Info("No activity check because EnableInactivityEmail is false")
-		return
-	}
-
-	if !s.platform.Config().FeatureFlags.EnableInactivityCheckJob {
-		mlog.Info("No activity check because EnableInactivityCheckJob feature flag is disabled")
-		return
-	}
-
-	_, sysValErr := s.Store().System().GetByName(inactivityEmailSent)
-	// if there is no error which may include *store.ErrNotFound, it means this check was already flagged as done
-	if sysValErr == nil {
-		return
-	}
-
-	inactivityDurationHoursEnv := os.Getenv("MM_INACTIVITY_DURATION")
-	inactivityDurationHours, parseError := strconv.ParseFloat(inactivityDurationHoursEnv, 64)
-	if parseError != nil {
-		// default to 100 hours
-		inactivityDurationHours = serverInactivityHours
-	}
-
-	// The first time this job runs. We check if the user has not made any posts in last inactivityDurationHours
-	// and remind them to use the workspace. If no posts have been made. We check the last time
-	// they logged in (session) for the last inactivityDurationHours and send a reminder.
-	lastPostAt, _ := s.Store().Post().GetLastPostRowCreateAt()
-	if lastPostAt != 0 {
-		posT := time.Unix(lastPostAt/1000, 0)
-		timeForLastPost := time.Since(posT).Hours()
-		if timeForLastPost > inactivityDurationHours {
-			s.takeInactivityAction()
-		}
-		return
-	}
-
-	lastSessionAt, _ := s.Store().Session().GetLastSessionRowCreateAt()
-	if lastSessionAt != 0 {
-		sesT := time.Unix(lastSessionAt/1000, 0)
-		timeForLastSession := time.Since(sesT).Hours()
-		if timeForLastSession > inactivityDurationHours {
-			s.takeInactivityAction()
-		}
-		return
-	}
-}
-
-func (s *Server) takeInactivityAction() {
-	siteURL := *s.platform.Config().ServiceSettings.SiteURL
-	if siteURL == "" {
-		mlog.Warn("No SiteURL configured")
-	}
-
-	properties := map[string]any{
-		"SiteURL": siteURL,
-	}
-	s.GetTelemetryService().SendTelemetry("inactive_server", properties)
-	users, err := s.Store().User().GetSystemAdminProfiles()
-	if err != nil {
-		mlog.Error("Failed to get system admins for inactivity check from Mattermost.")
-		return
-	}
-
-	for _, user := range users {
-
-		// See https://go.dev/doc/faq#closures_and_goroutines for why we make this assignment
-		user := user
-
-		if user.Email == "" {
-			mlog.Error("Invalid system admin email.", mlog.String("user_email", user.Email))
-			continue
-		}
-
-		name := user.FirstName
-		if name == "" {
-			name = user.Username
-		}
-
-		mlog.Debug("Sending inactivity reminder email.", mlog.String("user_email", user.Email))
-		s.Go(func() {
-			if err := s.EmailService.SendLicenseInactivityEmail(user.Email, name, user.Locale, siteURL); err != nil {
-				mlog.Error("Error while sending inactivity reminder email.", mlog.String("user_email", user.Email), mlog.Err(err))
-			}
-		})
-	}
-
-	// Mark that we sent emails.
-	sysVar := &model.System{Name: inactivityEmailSent, Value: "true"}
-	if err := s.Store().System().SaveOrUpdate(sysVar); err != nil {
-		mlog.Error("Unable to save INACTIVITY", mlog.Err(err))
-	}
-
-	// do some telemetry about sending the email
-	s.GetTelemetryService().SendTelemetry("inactive_server_emails_sent", properties)
-}