Migrate Channel.GetAllChannelMembersForUser to Sync by default (#11234)

* Migrate Channel.GetAllChannelMembersForUser to Sync by default

* fix gofmt for sqlstore/channel_store.go

app/user.go

@@ -199,13 +199,13 @@ func (a *App) indexUser(user *model.User) *model.AppError {
 		userTeamsIds = append(userTeamsIds, team.Id)
 	}
 
-	userChannelMembers := <-a.Srv.Store.Channel().GetAllChannelMembersForUser(user.Id, false, true)
-	if userChannelMembers.Err != nil {
-		return userChannelMembers.Err
+	userChannelMembers, err := a.Srv.Store.Channel().GetAllChannelMembersForUser(user.Id, false, true)
+	if err != nil {
+		return err
 	}
 
 	userChannelsIds := []string{}
-	for channelId := range userChannelMembers.Data.(map[string]string) {
+	for channelId := range userChannelMembers {
 		userChannelsIds = append(userChannelsIds, channelId)
 	}
 
@@ -2167,13 +2167,13 @@ func (a *App) GetViewUsersRestrictions(userId string) (*model.ViewUsersRestricti
 		return &model.ViewUsersRestrictions{Teams: teamIdsWithPermission}, nil
 	}
 
-	userChannelMembers := <-a.Srv.Store.Channel().GetAllChannelMembersForUser(userId, true, true)
-	if userChannelMembers.Err != nil {
-		return nil, userChannelMembers.Err
+	userChannelMembers, err := a.Srv.Store.Channel().GetAllChannelMembersForUser(userId, true, true)
+	if err != nil {
+		return nil, err
 	}
 
 	channelIds := []string{}
-	for channelId := range userChannelMembers.Data.(map[string]string) {
+	for channelId := range userChannelMembers {
 		channelIds = append(channelIds, channelId)
 	}