1
0
Π·Π΅Ρ€ΠΊΠ°Π»ΠΎ ΠΈΠ· https://github.com/rs-pro/activeadmin-quill_editor.git synced 2026-09-07 20:15:51 +03:00

πŸŽ‰ Support ActiveAdmin 2.x and code style improvements

- Add support ActiveAdmin for 2.x
- Add rubocop config
- Add frozen_string_literal to ruby files
- Apply changes to respect rubocop alerts
Π­Ρ‚ΠΎΡ‚ ΠΊΠΎΠΌΠΌΠΈΡ‚ содСрТится Π²:
Mattia Roccoberton
2019-06-15 19:50:57 +02:00
Ρ€ΠΎΠ΄ΠΈΡ‚Π΅Π»ΡŒ 598b2d75cf
ΠšΠΎΠΌΠΌΠΈΡ‚ 7265d2003a
11 ΠΈΠ·ΠΌΠ΅Π½Ρ‘Π½Π½Ρ‹Ρ… Ρ„Π°ΠΉΠ»ΠΎΠ²: 106 Π΄ΠΎΠ±Π°Π²Π»Π΅Π½ΠΈΠΉ ΠΈ 27 ΡƒΠ΄Π°Π»Π΅Π½ΠΈΠΉ

73
.rubocop.yml ΠžΠ±Ρ‹Ρ‡Π½Ρ‹ΠΉ Ρ„Π°ΠΉΠ»
ΠŸΡ€ΠΎΡΠΌΠΎΡ‚Ρ€Π΅Ρ‚ΡŒ Ρ„Π°ΠΉΠ»

@@ -0,0 +1,73 @@
require:
- rubocop-rspec
Rails:
Enabled: true
AllCops:
TargetRubyVersion: 2.3.8
TargetRailsVersion: 5.2
Exclude:
- db/schema.rb
- bin/*
- node_modules/**/*
# Temporary files
- tmp/**/*
Rails/InverseOf:
Enabled: false
Style/Documentation:
Enabled: false
Metrics/ClassLength:
# Default value is 100
Max: 150
Metrics/LineLength:
# Default is 80
Max: 120
Metrics/ModuleLength:
# Default is 100
Max: 150
Metrics/ParameterLists:
# Default is 5
Max: 6
RSpec/ExampleLength:
# Default is 10
Max: 20
Style/FrozenStringLiteralComment:
# Deface DOES edit strings in place
Exclude:
- 'app/overrides/**/*'
RSpec/MultipleExpectations:
# Default is 3
Max: 5
RSpec/NestedGroups:
# Default is 3
Max: 6
Metrics/AbcSize:
Max: 25
Metrics/BlockLength:
# This value double the rubocop default
Max: 50
Metrics/CyclomaticComplexity:
# This value double the rubocop default
Max: 12
Metrics/MethodLength:
# This value double the rubocop default
Max: 20
Metrics/PerceivedComplexity:
# Default is 7
Max: 10

ΠŸΡ€ΠΎΡΠΌΠΎΡ‚Ρ€Π΅Ρ‚ΡŒ Ρ„Π°ΠΉΠ»

@@ -1,4 +1,3 @@
source 'https://rubygems.org' source 'https://rubygems.org'
gemspec gemspec

ΠŸΡ€ΠΎΡΠΌΠΎΡ‚Ρ€Π΅Ρ‚ΡŒ Ρ„Π°ΠΉΠ»

@@ -7,7 +7,6 @@ An Active Admin plugin to use [Quill Rich Text Editor](https://github.com/quillj
## Install ## Install
- Update your Gemfile: `gem 'activeadmin_quill_editor'` (and execute *bundle*) - Update your Gemfile: `gem 'activeadmin_quill_editor'` (and execute *bundle*)
- For ActiveAdmin2 alpha use: `gem 'activeadmin_quill_editor', git: 'https://github.com/blocknotes/activeadmin_quill_editor', branch: 'aa2'`
- Add at the end of your ActiveAdmin styles (_app/assets/stylesheets/active_admin.scss_): - Add at the end of your ActiveAdmin styles (_app/assets/stylesheets/active_admin.scss_):
```css ```css
@import 'activeadmin/quill_editor_input'; @import 'activeadmin/quill_editor_input';

ΠŸΡ€ΠΎΡΠΌΠΎΡ‚Ρ€Π΅Ρ‚ΡŒ Ρ„Π°ΠΉΠ»

@@ -1,3 +1,3 @@
# encoding: utf-8 # frozen_string_literal: true
require "bundler/gem_tasks" require 'bundler/gem_tasks'

ΠŸΡ€ΠΎΡΠΌΠΎΡ‚Ρ€Π΅Ρ‚ΡŒ Ρ„Π°ΠΉΠ»

@@ -1,4 +1,6 @@
lib = File.expand_path('../lib', __FILE__) # frozen_string_literal: true
lib = File.expand_path('lib', __dir__)
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
require 'activeadmin/quill_editor/version' require 'activeadmin/quill_editor/version'
@@ -15,5 +17,5 @@ Gem::Specification.new do |spec|
spec.files = `git ls-files -z`.split("\x0") spec.files = `git ls-files -z`.split("\x0")
spec.require_paths = ['lib'] spec.require_paths = ['lib']
spec.add_runtime_dependency 'activeadmin', '~> 1.0' spec.add_runtime_dependency 'activeadmin', '>= 1.0'
end end

ΠŸΡ€ΠΎΡΠΌΠΎΡ‚Ρ€Π΅Ρ‚ΡŒ Ρ„Π°ΠΉΠ»

@@ -17,8 +17,6 @@ var initQuillEditors = function() {
[{ 'align': [] }, { list: 'ordered' }, { list: 'bullet' }], [{ 'align': [] }, { list: 'ordered' }, { list: 'bullet' }],
[{ 'color': [] }, { 'background': [] }], [{ 'color': [] }, { 'background': [] }],
['clean'], ['clean'],
// [{ 'size': ['small', false, 'large', 'huge'] }],
// [{ 'header': [1, 2, 3, 4, 5, 6, false] }],
] ]
}, },
placeholder: '', placeholder: '',
@@ -41,8 +39,6 @@ var initQuillEditors = function() {
for(var i = 0; i < editors.length; i++) { for(var i = 0; i < editors.length; i++) {
var input = editors[i].querySelector('input[type="hidden"]'); var input = editors[i].querySelector('input[type="hidden"]');
input.value = editors[i]['_quill-editor'].root.innerHTML; input.value = editors[i]['_quill-editor'].root.innerHTML;
// input.value = editors[i]['_quill-editor'].getContents();
// input.value = editors[i].querySelector( '.quill-editor-content' ).innerHTML;
} }
}; };
} }

ΠŸΡ€ΠΎΡΠΌΠΎΡ‚Ρ€Π΅Ρ‚ΡŒ Ρ„Π°ΠΉΠ»

@@ -1 +1,3 @@
# frozen_string_literal: true
require 'activeadmin/quill_editor/engine' require 'activeadmin/quill_editor/engine'

ΠŸΡ€ΠΎΡΠΌΠΎΡ‚Ρ€Π΅Ρ‚ΡŒ Ρ„Π°ΠΉΠ»

@@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'active_admin' require 'active_admin'
module ActiveAdmin module ActiveAdmin

ΠŸΡ€ΠΎΡΠΌΠΎΡ‚Ρ€Π΅Ρ‚ΡŒ Ρ„Π°ΠΉΠ»

@@ -1,5 +1,7 @@
# frozen_string_literal: true
module ActiveAdmin module ActiveAdmin
module QuillEditor module QuillEditor
VERSION = '0.1.4' VERSION = '0.2.0'
end end
end end

ΠŸΡ€ΠΎΡΠΌΠΎΡ‚Ρ€Π΅Ρ‚ΡŒ Ρ„Π°ΠΉΠ»

@@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'activeadmin/quill_editor' require 'activeadmin/quill_editor'
require 'formtastic/inputs/quill_editor_input' require 'formtastic/inputs/quill_editor_input'

ΠŸΡ€ΠΎΡΠΌΠΎΡ‚Ρ€Π΅Ρ‚ΡŒ Ρ„Π°ΠΉΠ»

@@ -1,3 +1,5 @@
# frozen_string_literal: true
module Formtastic module Formtastic
module Inputs module Inputs
class QuillEditorInput < Formtastic::Inputs::TextInput class QuillEditorInput < Formtastic::Inputs::TextInput