From 0fa164124fa6e2ca16d09c167115c8b3dc579167 Mon Sep 17 00:00:00 2001 From: Mattia Roccoberton Date: Tue, 1 Sep 2020 11:25:24 +0200 Subject: [PATCH] v0.2.4 --- README.md | 5 +++-- .../activeadmin/quill_editor_input.js | 20 +++++++++---------- .../activeadmin/_quill_editor_input.scss | 2 -- lib/activeadmin/quill_editor/version.rb | 2 +- .../app/assets/stylesheets/active_admin.scss | 1 + 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/README.md b/README.md index ed88afb..03807ca 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,8 @@ An Active Admin plugin to use [Quill Rich Text Editor](https://github.com/quillj - Update your Gemfile: `gem 'activeadmin_quill_editor'` (and execute *bundle*) - Add at the end of your ActiveAdmin styles (_app/assets/stylesheets/active_admin.scss_): -```css +```scss +@import 'activeadmin/quill_editor/quill.snow'; @import 'activeadmin/quill_editor_input'; ``` - Add at the end of your ActiveAdmin javascripts (_app/assets/javascripts/active_admin.js_): @@ -56,7 +57,7 @@ Take a look at [other ActiveAdmin components](https://github.com/blocknotes?utf8 ## Contributors -- [Mattia Roccoberton](http://blocknot.es) - creator, maintainer +- [Mattia Roccoberton](http://blocknot.es): author ## License diff --git a/app/assets/javascripts/activeadmin/quill_editor_input.js b/app/assets/javascripts/activeadmin/quill_editor_input.js index b3d0f4f..595638f 100644 --- a/app/assets/javascripts/activeadmin/quill_editor_input.js +++ b/app/assets/javascripts/activeadmin/quill_editor_input.js @@ -1,12 +1,4 @@ -window.onload = function() { - initQuillEditors(); -} - -$(document).on('has_many_add:after', function() { - initQuillEditors(); -}); - -var initQuillEditors = function() { +function initQuillEditors() { var editors = document.querySelectorAll('.quill-editor'); var default_options = { modules: { @@ -42,4 +34,12 @@ var initQuillEditors = function() { } }; } -}; +} + +$(document).ready( function() { + initQuillEditors(); +}); + +$(document).on('has_many_add:after', function() { + initQuillEditors(); +}); diff --git a/app/assets/stylesheets/activeadmin/_quill_editor_input.scss b/app/assets/stylesheets/activeadmin/_quill_editor_input.scss index d057f2f..b4037b3 100644 --- a/app/assets/stylesheets/activeadmin/_quill_editor_input.scss +++ b/app/assets/stylesheets/activeadmin/_quill_editor_input.scss @@ -1,5 +1,3 @@ -@import 'activeadmin/quill_editor/quill.snow'; - body.active_admin .quill-editor { display: inline-block; width: calc(80% - 22px); diff --git a/lib/activeadmin/quill_editor/version.rb b/lib/activeadmin/quill_editor/version.rb index f55070d..d85b526 100644 --- a/lib/activeadmin/quill_editor/version.rb +++ b/lib/activeadmin/quill_editor/version.rb @@ -2,6 +2,6 @@ module ActiveAdmin module QuillEditor - VERSION = '0.2.0' + VERSION = '0.2.4' end end diff --git a/spec/dummy/app/assets/stylesheets/active_admin.scss b/spec/dummy/app/assets/stylesheets/active_admin.scss index dd9ecf3..54c2446 100644 --- a/spec/dummy/app/assets/stylesheets/active_admin.scss +++ b/spec/dummy/app/assets/stylesheets/active_admin.scss @@ -11,6 +11,7 @@ @import 'active_admin/mixins'; @import 'active_admin/base'; +@import 'activeadmin/quill_editor/quill.snow'; @import 'activeadmin/quill_editor_input'; // Overriding any non-variable SASS must be done after the fact.